Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@npilon
Copy link
Contributor

@npilon npilon commented Jun 26, 2025

Extend work from #516 to support exports of Databook objects to XLSX with column widths, as already supported for Dataset. I read the new tests added in that PR and did not see any that would have covered the export_set lines that I've copied.

@claudep
Copy link
Contributor

claudep commented Jun 26, 2025

Thanks for your contribution. I guess it should still be welcome to add a test with the column_width parameter to a Databook export. And probably the docs needs a small update too.

@npilon
Copy link
Contributor Author

npilon commented Jun 26, 2025

Thanks for your contribution. I guess it should still be welcome to add a test with the column_width parameter to a Databook export. And probably the docs needs a small update too.

Thank you; I took another look at the tests from #516 and realized they would exercise my changes if adapted slightly, so I did so and then tried to reduce repetition between the two test helper methods.

I've also added some documentation; I'm a bit uncertain if this is enough as I'd assumed from the existing documentation that this would simply work and was surprised when it did not.

@npilon
Copy link
Contributor Author

npilon commented Jul 3, 2025

@claudep is there anything else needed from me on this change?

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@claudep claudep merged commit 172efb4 into jazzband:master Jul 5, 2025
22 checks passed
@hugovk hugovk changed the title feat: support column_width in xlsx format for databook exports Support column_width in xlsx format for databook exports Oct 15, 2025
@hugovk hugovk added the changelog: Added For new features label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Added For new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants