Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add dataset title adjustment for xls format #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
claudep merged 1 commit into from
Aug 27, 2025
Merged

Add dataset title adjustment for xls format #627

claudep merged 1 commit into from
Aug 27, 2025

Conversation

@TheSuperiorStanislav
Copy link
Contributor

@TheSuperiorStanislav TheSuperiorStanislav commented Aug 26, 2025

No description provided.

@TheSuperiorStanislav TheSuperiorStanislav marked this pull request as ready for review August 26, 2025 10:01
claudep
claudep reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! You should mention in the commit description that it fixes #303.

I'm not convinced that it's worth allowing customizing the replacement character. Maybe just having it as a class property would be enough. @hugovk, thoughts?

@TheSuperiorStanislav
Copy link
Contributor Author

TheSuperiorStanislav commented Aug 27, 2025

Thanks for the patch! You should mention in the commit description that it fixes #303.

I'm not convinced that it's worth allowing customizing the replacement character. Maybe just having it as a class property would be enough. @hugovk, thoughts?

About the replacement character, I made it similar to XLSX format

@claudep
Copy link
Contributor

claudep commented Aug 27, 2025

Ah yes, sorry for missing that. This is consistent then.

@claudep claudep merged commit b68752c into jazzband:master Aug 27, 2025
22 checks passed
@TheSuperiorStanislav
Copy link
Contributor Author

TheSuperiorStanislav commented Aug 28, 2025

@claudep Thanks for accepting. When can we expect this to be released?

@TheSuperiorStanislav TheSuperiorStanislav deleted the xls-title-fix branch August 28, 2025 02:28
@hugovk hugovk added the changelog: Added For new features label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudep claudep claudep approved these changes

Assignees

No one assigned

Labels

changelog: Added For new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheSuperiorStanislav @claudep @hugovk