Added unit test for #291 #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem with headers when a binary string is passed (like b'Authorization') I've added a function to decode such strings. It is not an elegant solution, but it works for me
Merged
jcgregorio
added a commit
that referenced
this pull request
Mar 3, 2015
There was a problem with headers when a binary string is passed (like b'Authorization').
This was referenced Mar 9, 2015
This was referenced Mar 24, 2015
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Feb 4, 2016
0.9.2: Changes not documented. 0.9.1: Fixes in this release: jcgregorio/httplib2#296 There was a problem with headers when a binary string is passed (like b'Authorization'). jcgregorio/httplib2#276 Default to doing DNS resolution through a proxy server if present.
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Feb 11, 2016
0.9.2: Changes not documented. 0.9.1: Fixes in this release: jcgregorio/httplib2#296 There was a problem with headers when a binary string is passed (like b'Authorization'). jcgregorio/httplib2#276 Default to doing DNS resolution through a proxy server if present.
This was referenced Jun 19, 2017
Merged
This was referenced Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the unit test for _convert_byte_str in python3/httplib2test.py so that
i026e/httplib2@93ba12c can be merged.
Previous pull request was #291.