Add confluentinc/cli to registry#10078
Conversation
Signed-off-by: if-gh <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request adds a new configuration file registry/confluent-cli.toml for the Confluent CLI. The reviewer identified an issue where the backend configuration will fail to locate the executable because the repository name is cli while the binary is named confluent. A suggestion was provided to explicitly specify the binary name using the bin option.
| @@ -0,0 +1,4 @@ | |||
| aliases = ["confluent"] | |||
| backends = ["github:confluentinc/cli"] | |||
There was a problem hiding this comment.
Since the repository name is cli but the actual binary inside the release is named confluent, the github backend will fail to locate the executable by default (it expects it to match the repository name cli). To fix this, specify the binary name explicitly using the bin option.
| backends = ["github:confluentinc/cli"] | |
| backends = [ | |
| { full = "github:confluentinc/cli", options = { bin = "confluent" } } | |
| ] |
Greptile SummaryThis PR adds
Confidence Score: 3/5Safe to add the registry entry itself, but the smoke test is likely wrong and will fail in CI. The backend reference and description look correct, but the test command (confluent --version) is undocumented by Confluent and the expected substring does not match the published output of the official confluent version subcommand. If the test runs in CI, it will likely fail, blocking the entry from being usable until fixed. registry/confluent-cli.toml — specifically the test field's cmd and expected values. Important Files Changed
Reviews (1): Last reviewed commit: "Add confluentinc/cli to registry" | Re-trigger Greptile |
| aliases = ["confluent"] | ||
| backends = ["github:confluentinc/cli"] | ||
| description = "CLI for Confluent Cloud and Confluent Platform" | ||
| test = { cmd = "confluent --version", expected = "confluent version v{{version}}" } |
There was a problem hiding this comment.
confluent version (subcommand, no --) outputs a multi-line block: `confluent - Confluent CLI
Version: v4.43.0
.... The string "confluent version v{{version}}"does not appear anywhere in that output.confluent --versionmay work as a Cobra-generated shorthand ifrootCmd.Versionis set, but it is not documented by Confluent and the--versionflag form usually outputsconfluent version 4.43.0(cobra default is{name} version {version}, and the version set in the binary may or may not carry the vprefix). If--versionis unsupported, the test will return a non-zero exit code; if the version string in the binary lacks thev` prefix, the expected substring won't match. Consider aligning with the documented command and its actual output.
| test = { cmd = "confluent --version", expected = "confluent version v{{version}}" } | |
| test = { cmd = "confluent version", expected = "Version: v{{version}}" } |
There was a problem hiding this comment.
Both commands are correct, with different output, e.g.
$ confluent --version
confluent version v4.63.0
$ confluent version
confluent - Confluent CLI
Version: v4.63.0
Git Ref: af7e8229
Build Date: 2026-05-22T00:44:00Z
Go Version: go1.26.1 (darwin/arm64)
Development: false
Add
confluent-clito registry.Related links: