chore(ci): revert switch back to github-hosted runners#10184
Conversation
📝 WalkthroughWalkthroughThis PR migrates GitHub Actions CI workflows from generic GitHub-hosted runners ( ChangesNamespace-Profile Runner and Cache Infrastructure
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ab2c58c. Configure here.
| "@ampcode/cli", | ||
| ] } }, | ||
| ] | ||
| backends = ["npm:@sourcegraph/amp"] |
There was a problem hiding this comment.
Amp uses deprecated npm name
Medium Severity
The amp registry entry points at npm:@sourcegraph/amp, but that package was renamed to @ampcode/cli and the old name is only a temporary npm alias. After the alias is removed, mise install amp and registry test-tool runs that rely on this backend can fail even though the prior entry used @ampcode/cli with allow_builds.
Reviewed by Cursor Bugbot for commit ab2c58c. Configure here.
Greptile SummaryThis PR reverts #10144 by moving all Linux and macOS CI jobs back to Namespace runner profiles and replacing
Confidence Score: 5/5Safe to merge — all changes are a well-scoped revert to a previously working CI configuration. Every change is a mechanical runner migration: swap ubuntu-latest/macos-latest for Namespace profiles and replace Swatinem/rust-cache with nscloud-cache-action. The configuration was in production before #10144 temporarily reverted it, so the risk of introducing a novel regression is very low. .github/workflows/test.yml — the lint job has the nscloud-cache-action step placed after the first taiki-e/install-action call, which was already flagged in a prior thread. Important Files Changed
Reviews (2): Last reviewed commit: "chore(ci): revert switch back to github-..." | Re-trigger Greptile |
| - uses: rui314/setup-mold@9c9c13bf4c3f1adef0cc596abc155580bcb04444 # v1 | ||
| - uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2 # zizmor: ignore[cache-poisoning] save-if already gates writes to main/release | ||
| with: | ||
| save-if: ${{ github.ref == 'refs/heads/main' || github.ref == 'refs/heads/release' }} | ||
| - uses: taiki-e/install-action@51cd0b8c0499559d9a4d75c0f5c67bec3a894ec8 # v2 | ||
| with: | ||
| tool: cargo-deny,cargo-msrv,cargo-machete | ||
| - uses: namespacelabs/nscloud-cache-action@15799a6b54e5765f85b2aac25b3f0df43ed571c0 # v1 | ||
| with: | ||
| path: | | ||
| ~/.cargo/registry | ||
| ~/.cargo/git | ||
| ~/.cargo/.global-cache | ||
| ~/.cache/sccache | ||
| - uses: taiki-e/install-action@51cd0b8c0499559d9a4d75c0f5c67bec3a894ec8 # v2 | ||
| with: { tool: sccache } |
There was a problem hiding this comment.
The
nscloud-cache-action step is placed after the first taiki-e/install-action call (which installs cargo-deny, cargo-msrv, and cargo-machete). Because nscloud mounts cache directories when the action runs, any downloads that happen before this step won't benefit from cache restore. Every other job in this PR places the cache action immediately after checkout. Moving it up gives the tool-install steps the same cache benefit as the rest of the pipeline.
| - uses: rui314/setup-mold@9c9c13bf4c3f1adef0cc596abc155580bcb04444 # v1 | |
| - uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2 # zizmor: ignore[cache-poisoning] save-if already gates writes to main/release | |
| with: | |
| save-if: ${{ github.ref == 'refs/heads/main' || github.ref == 'refs/heads/release' }} | |
| - uses: taiki-e/install-action@51cd0b8c0499559d9a4d75c0f5c67bec3a894ec8 # v2 | |
| with: | |
| tool: cargo-deny,cargo-msrv,cargo-machete | |
| - uses: namespacelabs/nscloud-cache-action@15799a6b54e5765f85b2aac25b3f0df43ed571c0 # v1 | |
| with: | |
| path: | | |
| ~/.cargo/registry | |
| ~/.cargo/git | |
| ~/.cargo/.global-cache | |
| ~/.cache/sccache | |
| - uses: taiki-e/install-action@51cd0b8c0499559d9a4d75c0f5c67bec3a894ec8 # v2 | |
| with: { tool: sccache } | |
| - uses: rui314/setup-mold@9c9c13bf4c3f1adef0cc596abc155580bcb04444 # v1 | |
| - uses: namespacelabs/nscloud-cache-action@15799a6b54e5765f85b2aac25b3f0df43ed571c0 # v1 | |
| with: | |
| path: | | |
| ~/.cargo/registry | |
| ~/.cargo/git | |
| ~/.cargo/.global-cache | |
| ~/.cache/sccache | |
| - uses: taiki-e/install-action@51cd0b8c0499559d9a4d75c0f5c67bec3a894ec8 # v2 | |
| with: | |
| tool: cargo-deny,cargo-msrv,cargo-machete | |
| - uses: taiki-e/install-action@51cd0b8c0499559d9a4d75c0f5c67bec3a894ec8 # v2 | |
| with: { tool: sccache } |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.16 x -- echo |
17.0 ± 0.7 | 15.6 | 19.8 | 1.00 |
mise x -- echo |
17.6 ± 1.9 | 16.0 | 56.9 | 1.04 ± 0.12 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.16 env |
17.0 ± 0.8 | 15.5 | 21.2 | 1.00 |
mise env |
17.5 ± 0.8 | 15.8 | 21.2 | 1.03 ± 0.07 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.16 hook-env |
17.6 ± 0.7 | 16.0 | 20.5 | 1.00 |
mise hook-env |
18.2 ± 0.9 | 16.4 | 23.1 | 1.03 ± 0.07 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.16 ls |
14.1 ± 0.6 | 12.8 | 17.0 | 1.00 |
mise ls |
14.5 ± 0.7 | 13.2 | 17.0 | 1.03 ± 0.07 |
xtasks/test/perf
| Command | mise-2026.5.16 | mise | Variance |
|---|---|---|---|
| install (cached) | 129ms | 131ms | -1% |
| ls (cached) | 56ms | 56ms | +0% |
| bin-paths (cached) | 61ms | 62ms | -1% |
| task-ls (cached) | 119ms | 121ms | -1% |
Reverts a3126f5 (chore(ci): switch back to github-hosted runners).
ab2c58c to
e229aeb
Compare


Summary
Testing
This PR was generated by an AI coding assistant.
Note
Medium Risk
CI execution and artifact caching depend on external Namespace infrastructure; misconfiguration could block merges or slow builds without affecting shipped product code.
Overview
This PR moves CI back onto Namespace runner profiles instead of default GitHub-hosted labels (
ubuntu-latest/macos-latest) for docs, test, registry, hyperfine, release-plz, release tarballs, and related jobs. Linux jobs usenamespace-profile-endev-linux-amd64(or large for heavy Rust/benchmark/release builds); macOS unit tests and release macOS tarballs usenamespace-profile-endev-macos-arm64, with per-workflowoverrides.cache-tagvalues for Rust cache scoping.For Rust compilation workflows,
Swatinem/rust-cacheis removed in favor ofnamespacelabs/nscloud-cache-action, caching~/.cargo/registry,~/.cargo/git,~/.cargo/.global-cache, and~/.cache/sccachealongside existing sccache setup. The lint job drops the prior rust-cache restore/save-if block and relies on nscloud paths only. Windows jobs in the touched files remain onwindows-latestwhere unchanged.Reviewed by Cursor Bugbot for commit e229aeb. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit