registry: add metabase-cli (npm:@metabase/cli)#10367
Conversation
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (1)
π WalkthroughWalkthroughA new registry configuration file is added for the Metabase CLI package, specifying its npm backend source, descriptive metadata, and a version-check test command that validates against a templated version value. ChangesMetabase CLI Registry Entry
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~2 minutes Possibly related PRs
Poem
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
βοΈ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryAdds
Confidence Score: 5/5Safe to merge β a single, minimal TOML file with no logic changes and no impact on existing registry entries. The change is a single three-line TOML file. The backends, description, and test fields are all well-formed and match the conventions used by other npm-backed entries. There is nothing in the file that could break existing tooling, and the acceptance of the npm tier-3 backend is an editorial decision for the maintainer. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "registry: add metabase-cli (npm:@metabas..." | Re-trigger Greptile |
What
Adds a registry short name for the official Metabase CLI, so users can
mise use metabase-cliinstead ofmise use npm:@metabase/cli.Popularity summary
@metabaseorg.Backend choice
npm is the only distribution channel today β there are no GitHub release binaries yet, so no aqua/github option exists. I'm aware npm is a tier-3 backend with a very high bar; happy to close this if it doesn't meet it, or to revisit with a github/aqua primary backend once we ship standalone binaries. The package has no native dependencies and works with lifecycle scripts disabled.
Testing
Verified locally:
Summary by CodeRabbit