refactor(aqua): stop canonicalizing archive format aliases#10404
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesArchive format alias preservation
Possibly related PRs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryThis PR removes the redundant alias-to-canonical rewriting (
Confidence Score: 5/5Safe to merge — the deleted code was purely redundant; ExtractionFormat::from_ext handles the aliases identically downstream. The deleted match arms and their replacements are functionally equivalent end-to-end. The strum serialize attributes on ExtractionFormat (tgz → TarGz, txz → TarXz, tbz/tbz2 → TarBz2) were already the canonical mapping path used by every other caller of from_ext, so removing the pre-normalization in types.rs changes nothing observable. The two new tests directly verify both the detected and explicit-format paths. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "refactor(aqua): stop canonicalizing arch..." | Re-trigger Greptile |
Summary
tgz,txz,tbz, andtbz2tar.*strings inside aqua-registryContext
This is PR 3 from the aqua extraction cleanup plan.
ExtractionFormat::from_extalready understands the supported aliases at extraction time, so aqua-registry does not need to rewrite aqua's literal format strings before returning them.PR #10104 is stacked on this branch locally. Target branch remains
main.Tests
cargo fmt --checkmise x cargo -- cargo test -p aqua-registry test_format_detects_literal_aqua_aliasesmise x cargo -- cargo test -p aqua-registry test_format_preserves_explicit_aqua_aliasesSummary by CodeRabbit
Bug Fixes
Tests