Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(deps): bump usage to 3.5.2#10498

Merged
jdx merged 1 commit into
mainfrom
codex/bump-usage-3-5-2
Jun 17, 2026
Merged

chore(deps): bump usage to 3.5.2#10498
jdx merged 1 commit into
mainfrom
codex/bump-usage-3-5-2

Conversation

@jdx

@jdx jdx commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • bump usage-lib from 3.5.0 to 3.5.2
  • bump the locked usage CLI from 3.5.0 to 3.5.2
  • regenerate zsh completions so _mise includes emulate -L zsh

Context

usage 3.5.2 includes the zsh completion fix for isolating generated completion function options, which avoids user zsh options such as KSH_ARRAYS affecting the tab-separated completion row parsing.

This intentionally leaves min_usage_version at 3.5.

Validation

  • cargo fmt --check
  • cargo check --locked -p mise --all-features
  • git diff --check
  • PATH="/tmp/usage-cli-3.5.2/bin:$PATH" mise run render:usage
  • PATH="/tmp/usage-cli-3.5.2/bin:$PATH" mise run render:completions
  • verified ./target/debug/mise usage emits min_usage_version "3.5"
  • verified ./target/debug/mise completion zsh emits emulate -L zsh

This PR was generated by an AI coding assistant.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed zsh shell completion compatibility to ensure proper option scoping behavior.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 4de685e7-028a-4e50-afb1-a05506246e94

📥 Commits

Reviewing files that changed from the base of the PR and between c6cc56b and 4a174f5.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • mise.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • completions/_mise
🚧 Files skipped from review as they are similar to previous changes (1)
  • completions/_mise

📝 Walkthrough

Walkthrough

A single line, emulate -L zsh, is inserted at the start of the _mise completion function body in the zsh completion script. This sets zsh emulation mode with locally scoped shell options for the duration of the completion function.

Changes

zsh Completion Emulation Fix

Layer / File(s) Summary
Add emulate -L zsh to _mise function
completions/_mise
Inserts emulate -L zsh as the first statement in the _mise function body, enabling zsh emulation with locally scoped options for the completion logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • jdx/mise#10181: Directly modifies the same _mise zsh completion function, rewriting how completion entries are built and described.
  • jdx/mise#10313: Also modifies the _mise zsh completion function, changing how usage complete-word results are parsed and passed to compadd.

Poem

🐇 A single line, so small yet true,
emulate -L zsh — hooray, we're through!
Options scoped with local care,
completions work beyond compare.
The rabbit hops with zsh delight! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'chore(deps): bump usage to 3.5.2' describes a dependency version bump, but the main change is zsh completion regeneration with emulate -L zsh fix. Update title to reflect the primary change: consider 'fix(zsh): add emulate -L zsh to completion function' or 'chore: bump usage to 3.5.2 and regenerate zsh completions'
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security

socket-security Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​usage-lib@​3.5.0 ⏵ 3.5.2991009310070

View full report

@greptile-apps

greptile-apps Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps usage-lib and the locked usage CLI from 3.5.0 to 3.5.2, and regenerates completions/_mise to include emulate -L zsh at the top of _mise(), fixing completion breakage under user zsh options like KSH_ARRAYS.

  • Cargo.lock / mise.lock: Version and checksums updated to 3.5.2 across all platforms; changes are mechanically consistent.
  • completions/_mise: emulate -L zsh added as the first statement in _mise(), correctly scoping the function's option environment.
  • Missing change: The PR description states that min_usage_version is raised to "3.5.2" in both src/cli/usage.rs and mise.usage.kdl, but neither file was modified — both still read "3.5". Without this floor, a developer regenerating completions with usage 3.5.0 or 3.5.1 will pass the version gate and produce a completion file without the emulate -L zsh fix.

Confidence Score: 4/5

Safe to merge for end users (the shipped completion file is correct), but the min_usage_version floor was not raised as the PR description claims, leaving the regeneration workflow unguarded.

The three changed files are all correct: the library bump is pinned with new checksums, the completion fix is properly placed, and the lock file covers every platform. The only gap is that src/cli/usage.rs and mise.usage.kdl still say min_usage_version "3.5" instead of "3.5.2", meaning a developer who regenerates completions using usage 3.5.0 or 3.5.1 will silently produce a file without emulate -L zsh, contradicting the PR's own validation claims.

src/cli/usage.rs line 93 and mise.usage.kdl line 1 — both need "3.5" updated to "3.5.2".

Important Files Changed

Filename Overview
Cargo.lock Bumps usage-lib from 3.5.0 to 3.5.2 with updated checksum — routine lock file update.
completions/_mise Adds emulate -L zsh as first line of _mise() to isolate completion option parsing from user zsh options like KSH_ARRAYS — correct fix, correctly placed.
mise.lock Updates locked usage CLI from 3.5.0 to 3.5.2 with new platform-specific checksums and download URLs — all platforms covered consistently.

Reviews (2): Last reviewed commit: "chore(deps): bump usage to 3.5.2" | Re-trigger Greptile

@jdx jdx force-pushed the codex/bump-usage-3-5-2 branch from c6cc56b to 4a174f5 Compare June 17, 2026 02:40
@jdx jdx enabled auto-merge (squash) June 17, 2026 02:42
@github-actions

Copy link
Copy Markdown

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.11 x -- echo 20.3 ± 0.8 18.8 23.6 1.00
mise x -- echo 21.2 ± 1.9 19.7 53.1 1.05 ± 0.10

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.11 env 20.5 ± 2.1 18.3 35.0 1.00
mise env 21.0 ± 1.3 18.9 27.5 1.02 ± 0.12

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.11 hook-env 22.1 ± 1.7 18.8 31.2 1.00
mise hook-env 22.2 ± 1.6 19.5 30.5 1.01 ± 0.11

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.11 ls 17.8 ± 1.2 15.9 25.0 1.00
mise ls 19.2 ± 1.9 16.5 28.3 1.08 ± 0.13

xtasks/test/perf

Command mise-2026.6.11 mise Variance
install (cached) 148ms 149ms +0%
ls (cached) 65ms 66ms -1%
bin-paths (cached) 70ms 73ms -4%
task-ls (cached) 137ms 139ms -1%

@jdx jdx merged commit 7ffe8ae into main Jun 17, 2026
34 checks passed
@jdx jdx deleted the codex/bump-usage-3-5-2 branch June 17, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant