Codestin Search App

risu729 · 2025-08-20T17:20:33Z

…stry'

git-subtree-dir: aqua-registry git-subtree-split: 5f39141617673c36936cb2f51a09f183acadb0b5

Copilot

Pull Request Overview

This pull request removes the aqua-registry submodule by converting all submodule package definitions into standalone files. The PR addresses the refactoring of the aqua-registry structure to eliminate dependency on Git submodules.

Key Changes:

Removes aqua-registry submodule dependency
Converts all package definitions to standalone YAML files
Maintains complete package registry functionality through direct file inclusion

Reviewed Changes

Copilot reviewed 300 out of 4034 changed files in this pull request and generated no comments.

File	Description
Multiple registry.yaml files	Package definition files for various tools including registries for Pluralith CLI, Gex, DevDash, and many other developer tools
Multiple pkg.yaml files	Package version specifications corresponding to each tool's registry definition
Multiple scaffold.yaml files	Configuration files for package generation and maintenance workflows

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

jdx · 2025-08-20T18:10:11Z

release-plz has some logic that needs to be updated too that updates aqua-registry during the release commit, we should squash all the changes from aqua-registry for the release branch

risu729 · 2025-08-20T18:53:47Z

GitHub cannot list all changed files, unfortunately.
Could you check 4510e51?
For else, I added --exclude aqua-registry for hk because I couldn't find a global exclude in the config.

349a2849b4 chore: update sqldef/sqldef/psqldef v2.0.9 to v2.0.10 (#40371) e0ad00ea84 chore: update sqldef/sqldef/mssqldef v2.0.9 to v2.0.10 (#40370) 93f11756f6 chore: update protocolbuffers/protobuf-go/protoc-gen-go v1.36.7 to v1.36.8 (#40369) cf807b40e2 chore: update yarnpkg/berry @yarnpkg/cli/4.9.2 to @yarnpkg/cli/4.9.3 (#40368) git-subtree-dir: aqua-registry git-subtree-split: 349a2849b456bf4f4da0ad066368664ffdff1b22

…istry-subtree

risu729 · 2025-08-20T19:08:41Z

As you see, the commit Squashed 'aqua-registry/' changes from... is not signed. I'm not sure but it might not be signed in the release PR too.

jdx · 2025-08-20T19:21:53Z

 	man/
 git clean -df
 git checkout -B release
+git subtree pull --squash --prefix=aqua-registry https://github.com/aquaproj/aqua-registry main


I think this needs to be done after the commit but I could be wrong

Fixed. ~~I think the order doesn't matter~~ It does, uncommitted changes will cause an error.

jdx · 2025-08-20T19:22:11Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no bugs!

jdx · 2025-08-20T23:36:14Z

as a follow-up we should remove the logic in the aqua backend that fetches registry information from mise-versions

risu729 · 2025-08-21T19:29:47Z

I'll work on it.
Btw, do you care about this?
The simpler git clone method is good, but the modified .gitattributes is not preserved. I think we can just overwrite it after the clone.

risu729 · 2025-08-21T19:52:38Z

I'm not sure how many people are using aqua.registry_url, but I see some problems with it.
At first, aqua supports multiple registries, and each tool needs to specify which registry to use.
https://aquaproj.github.io/docs/reference/config/#registries
Currently, I think the only reason to use this option is to use a fork of aquaproj/aqua-registry.

Also, we need to clear the cache (.cache/mise/aqua-registry/) to change this. I think we should save the registry_url with the cache.

Shall we remove this option, or should we support multiple registries as aqua?
I think it's useful if someone wants to install their private tool with aqua, but the github backend should be able to resolve most cases.

If we remove it, we can simply clone aquaproj/aqua-registry when the baked_registry option is disabled (to use the latest registry), or fetch each registry from GitHub.
e.g. https://raw.githubusercontent.com/aquaproj/aqua-registry/refs/heads/main/pkgs/BurntSushi/ripgrep/registry.yaml
I'm not really sure about the purpose of mise-versions, but if it was to avoid many API requests to GitHub, I think it's safe to remove the proxy because I don't expect many people to disable the option.

jdx · 2025-08-21T22:30:36Z

I'm not sure how many people are using aqua.registry_url, but I see some problems with it.
At first, aqua supports multiple registries, and each tool needs to specify which registry to use.

it's a good question, but I doubt many people if any are using it. I think what we should have is the ability to have additional aqua registries at some point. Maybe we want to deprecate changing the default?

I had a look at the code though and I think we could remove the mise-versions stuff without touching that part of the code, but I could be wrong. If you wanted to work on multiple aqua registries I would be massively in favor, I know a few people have asked for that.

I'm not really sure about the purpose of mise-versions, but if it was to avoid many API requests to GitHub

it was for performance since cloning the repo and fetching the latest version is a lot slower than an http request

The aqua registry is now always baked in, so the fallback is not required. #6082 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

risu729 · 2025-08-22T15:33:13Z

Thanks, I'll work on multiple registries later. I think we can have it as a tool option.

risu729 · 2026-05-31T17:49:57Z

Follow-up for the custom aqua registry discussion in this PR: opened draft PR #10179 to support multiple ordered custom aqua registries: #10179

The implementation keeps the existing single-string aqua.registry_url syntax, adds list/comma-separated env support, scopes caches by registry URL/source, checks registries in configured order, and falls back to the baked registry when enabled. Aqua registry aliases remain registry-local; cross-registry/mise shorthand aliases should use [tool_alias].

This comment was generated by an AI coding assistant.

risu729 added 6 commits August 21, 2025 02:46

refactor: remove aqua-registry submodule

46c9784

chore: remove submodules checkout in github actions

daf2f5a

chore: remove aqua-registry submodule from build scripts

4510e51

Merge commit '9f7e54ef0d88f83387e8e7e915c7c1e0e6dd9656' as 'aqua-regi…

ab762b4

…stry'

Squashed 'aqua-registry/' content from commit 5f39141617

9f7e54e

git-subtree-dir: aqua-registry git-subtree-split: 5f39141617673c36936cb2f51a09f183acadb0b5

chore: update release-plz script

d749bcf

Copilot AI review requested due to automatic review settings August 20, 2025 17:20

Copilot AI reviewed Aug 20, 2025

View reviewed changes

risu729 changed the title ~~refactor: remove aqua-registry submodule~~ chore: replace submodule with subtree Aug 20, 2025

risu729 and others added 6 commits August 21, 2025 03:24

chore: remove unused codes

b1a783a

chore: ignore aqua-registry by hk

e734e48

chore: checkout vfox-npm submodule

c7eadb0

chore: remove unused variable from shellscript

6cbfd36

chore: ignore aqua-registry

d09f41e

[autofix.ci] apply automated fixes

fcd63bb

chore: fix release-plz task

fc30a1f

risu729 added 3 commits August 21, 2025 04:58

chore: exclude aqua-registry lang stats

3409402

Merge commit '2792a9d7f5b98a7b6b2d74dac1bcc5ff8cf4383d' into aqua-reg…

13125ea

…istry-subtree

jdx reviewed Aug 20, 2025

View reviewed changes

cursor Bot reviewed Aug 20, 2025

View reviewed changes

chore: reorder release branch commits

7947e34

jdx merged commit 87d9572 into jdx:main Aug 20, 2025
55 of 57 checks passed

mise-en-dev mentioned this pull request Aug 21, 2025

chore: release 2025.8.15 #6081

Merged

risu729 deleted the aqua-registry-subtree branch August 21, 2025 08:09

risu729 mentioned this pull request Aug 22, 2025

fix(aqua): remove mise-versions aqua registry #6097

Merged

Uh oh!

Conversation

risu729 commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

jdx commented Aug 20, 2025

Uh oh!

risu729 commented Aug 20, 2025

Uh oh!

risu729 commented Aug 20, 2025

Uh oh!

jdx Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

risu729 Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdx commented Aug 20, 2025

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

✅ Bugbot reviewed your changes and found no bugs!

Uh oh!

Uh oh!

jdx commented Aug 20, 2025

Uh oh!

risu729 commented Aug 21, 2025

Uh oh!

risu729 commented Aug 21, 2025

Uh oh!

jdx commented Aug 21, 2025

Uh oh!

risu729 commented Aug 22, 2025

Uh oh!

risu729 commented May 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

risu729 commented Aug 20, 2025 •

edited

Loading

jdx Aug 20, 2025 •

edited

Loading

risu729 Aug 20, 2025 •

edited

Loading