Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clone of spark404's Parent of Parent fix#18

Merged
jglick merged 4 commits into
jenkinsci:masterfrom
quidryan:parentofparent
Mar 8, 2013
Merged

Clone of spark404's Parent of Parent fix#18
jglick merged 4 commits into
jenkinsci:masterfrom
quidryan:parentofparent

Conversation

@quidryan

@quidryan quidryan commented Mar 7, 2013

Copy link
Copy Markdown
Member

The pull request via #15 didn't seem to work. Full credit goes to @spark404 for this original pull request.

spark404 and others added 2 commits March 6, 2013 22:52
that eventually triggered this buikd. Not just the direct parent. Added a recursive call to getBuild to make that happen.

Including unit test scenario with a grandparent job which has the artifact that the job wants.
@buildhive

Copy link
Copy Markdown

Jenkins » copyartifact-plugin #23 SUCCESS
This pull request looks good
(what's this?)

@jglick

jglick commented Mar 7, 2013

Copy link
Copy Markdown
Member

What about spark404@dee6d89 from #15? I guess it is not applicable here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearer to consolidate: have one block for if (cause instanceof UpstreamCause) inside of which is a nested test for if (jobName.equals(((UpstreamCause)cause).getUpstreamProject())). (In which case you can also introduce a variable for (UpstreamCause)cause.)

@quidryan

quidryan commented Mar 8, 2013

Copy link
Copy Markdown
Member Author

@jglick I was just taking spark404's version. Good comments though, implemented them. I tested in an Jenkins instance too.

@buildhive

Copy link
Copy Markdown

Jenkins » copyartifact-plugin #25 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@quidryan

quidryan commented Mar 8, 2013

Copy link
Copy Markdown
Member Author

Cloudbees ran so slow we crossed a 10 second threshold. Extending to 20 seconds.

@buildhive

Copy link
Copy Markdown

Jenkins » copyartifact-plugin #26 SUCCESS
This pull request looks good
(what's this?)

@quidryan

quidryan commented Mar 8, 2013

Copy link
Copy Markdown
Member Author

There we go, it just needed a little more time.

jglick added a commit that referenced this pull request Mar 8, 2013
Clone of spark404's Parent of Parent fix
@jglick jglick merged commit b6fda7c into jenkinsci:master Mar 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants