feat: add JDK25 images#2146
Conversation
dduportal
left a comment
There was a problem hiding this comment.
This PR seems to have test failures that we don't have on the master branch. Are they JDK25 related?
They're related to the changes in this PR, hence the switch into a draft. Preparing a report. |
5021975 to
2e70741
Compare
|
Thanks for the pull request! I built the Java 25 Alpine container and tried to start it. Commands I used were: It failed with the message: I don't see that message when I run with a full Java 25 JDK (/opt/jdk-25/bin/java), so I assume the failure is related to the Java 25 modules system. I removed the There is a closed Jetty issue that mentions FileSystemNotFoundException: |
Doesn't look relevant, this seems to be it: https://stackoverflow.com/a/77115516/4951015 |
Blocking issue #2148 resolved with #2162, and default
Adding DetailsI need more time to study the method explained in https://stackoverflow.com/a/77115516/4951015 and find out what's missing. (No error when skipping |
7a58917 to
1973886
Compare
|
Is there a reason against starting with the full JDK? Yes I know we can get a few megabytes less by "generating" our own JDK. But it looks like a lot of trouble (on each JDK upgrade we have this kind of exchange) and a lot of risks (what if our tests do not cover all cases using JDK modules) while we could already provide something to the end users? I would prefer having the discussion at SIG platform level. I believe we should automate testing a "stripped" JDK way earlier than in the Docker image which is only packaging. If ci.jio could run some ATH branches which runs with stripped (and documented) JDKs, that would feel safer and easier to "only" reproduce here. Thoughts? |
I think that it is a good idea to accept the full JDK 25 in the short term.
I like that idea very much! |
|
+1, and that would allow us to ship a Weekly release with JDK25 before the next LTS. |
|
Overall build duration increased from 22 min to 25 min with this additional JDK, not bad 🙂 |
Refer to pull requests: * jenkinsci/docker#2146 * jenkinsci/docker-ssh-agent#549 * jenkinsci/docker-agents#1061 Address checklist items in comment: * jenkinsci/docker#2121 (comment)
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* feat: add JDK25 images * no jlink for now
* Backported changes added to 2.541.1 chaneglog * Add changes through 2.534 * Spell Red Hat correctly in weekly changelog * Better phrasing for GPG signing key, URL fixes * More LTS changelog refinements * Add banner for new GPG signing key for Linux packages * Add content security policy section to upgrade guide Also extends the RPM changes with one more sentence * Add Windows Server 2022 container images to changelog and upgrade guide Refer to pull request: * jenkinsci/docker#2170 Addresses checklist items in comment: * jenkinsci/docker#2167 (comment) * Add JDK 25 container images to weekly and LTS changelog Refer to pull requests: * jenkinsci/docker#2146 * jenkinsci/docker-ssh-agent#549 * jenkinsci/docker-agents#1061 Address checklist items in comment: * jenkinsci/docker#2121 (comment) * Fix YAML syntax errors * Add more details on the repository signing update #8690 (comment) * Use rpm-stable URL in LTS changelog #8690 (comment) * Controller only drops support for Windows Server 2019 #8690 (comment) * Windows server container is controller only Updated with current state for comment: #8690 (comment) May change based on the results of discussions in: * jenkinsci/docker#2197 * Windows Server 2022 added to 2.541.1 * Windows Server 2019 containers still available for weekly * Windows container images in the upgrade guide * Use correct pull request for Windows Server Core 2022 * Simplify the Java 25 addition to the weekly changelog * Do not mention agents in upgrade guide * fix: debug syntax error(s) in content/_data/changelogs/lts.yml --------- Co-authored-by: Kris Stern <[email protected]> Co-authored-by: Kris Stern <[email protected]>
This PR adds JDK25 images.
Ref:
Testing done
make testSubmitter checklist