Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

timja
Copy link
Member

@timja timja commented Jan 16, 2020

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this seems reasonable to me.

</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>jackson2-api</artifactId>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious as to why a new dependency needs to be introduced.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-api-plugin depends on this plugin, so it's not really adding a new dep, but the released version is very out-dated (causing enforcer errors).

If someone wants to release github-api-plugin then this dependency change is unneeded

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/github-api-plugin#35 is going to remove this dependency. Hopefully that gets released and you can just depend on the new version. @bitwiseman are you planning a new release soon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, there shouldn't be a conflict anymore and then this dependency could be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@res0nance
I'm planning to release as soon as I reasonably can, in the meanwhile. I'll take this PR as it stands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this as of #269 anyway.

@bitwiseman bitwiseman merged commit 7179854 into jenkinsci:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants