Add GitHub branch and pull request info to the 'Details' widget #826
+265
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Feb 18, 2025
src/main/java/org/jenkinsci/plugins/github_branch_source/ScmDetailGroup.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Feb 18, 2025
| SCMRevisionAction scmRevisionAction = getObject().getAction(SCMRevisionAction.class); | ||
| SCMRevision revision = scmRevisionAction.getRevision(); | ||
|
|
||
| if (revision instanceof AbstractGitSCMSource.SCMRevisionImpl abstractRevision) { |
There was a problem hiding this comment.
potentially belongs in the Git plugin? and then this plugin only handles the pull request one?
Although not sure if you could figure out the link from there, maybe you can though?
6 tasks
janfaracik
commented
Sep 26, 2025
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>github-api</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Needs to be removed when scm-api has been released.
|
Opening for review to get thoughts. Is the information we show the right information - e.g. is commit hash needed? Is my usage of the API correct/are there more efficient ways of doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.504.1 introduced a new
DetailAPI, allowing core and plugin developers to attach details and groups to objects in Jenkins. This is currently only used byRunin core.This PR adds relevant Git info to
ScmDetailGroup, provided by scm-api-plugin.Description
For branches show:
For pull requests show:
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify