Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JENKINS-65892 Support macro tokens in github context label #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

JENKINS-65892 Support macro tokens in github context label #5

wants to merge 1 commit into from
+41 −20

Conversation

akomakom
Copy link

  • [x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x ] Ensure that the pull request title represents the desired changelog entry
  • [x ] Please describe what you did
  • [x ] Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Adds build-time token substitution to the context label. No tests since the plugin has none in the first place.

See https://issues.jenkins.io/browse/JENKINS-65892

@akomakom akomakom force-pushed the token-macro-support branch from 9bd848b to 63a65f6 Compare June 16, 2021 18:29
@trent-abc
Copy link

This is a beautiful PR. Since this is a dead repository, For those wondering how to implement this in your own Jenkins:

# uninstall github-scm-trait-notification-context-plugin, restart Jenkins.
git clone [email protected]:akomakom/github-scm-trait-notification-context-plugin.git
git checkout token-macro-support
mvn hpi:hpl -DjenkinsHome=$JENKINS_HOME
mvn clean package
mvn hpi:hpi
# On the job configuration
# Custom Github Notification Context
# ecs-cicd-${JOB_NAME}```

@l3ender
Copy link
Contributor

l3ender commented Sep 24, 2023

Thank you for your PR and interest in this plugin! I've recently taken on maintenance of this plugin and am reviewing existing submissions.

Is this feature/PR still desired to be incorporated into the plugin? If so, can you please update the PR and merge latest released changes? The plugin has been modernized/updated to be current with standards, as well as a few releases of other features.

Let me know if you have any questions--thanks!

@gjabouley-invn gjabouley-invn mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akomakom @trent-abc @l3ender