Support withCredentials on GitLabApiToken(Impl)#1754
Merged
krisstern merged 7 commits intoApr 7, 2025
Conversation
67704f7 to
3f23564
Compare
Member
|
Thanks @tiago-teixeira5! I will give this a review over the next few days |
krisstern
requested changes
Apr 6, 2025
Co-authored-by: Kris Stern <[email protected]>
krisstern
approved these changes
Apr 7, 2025
krisstern
left a comment
Member
There was a problem hiding this comment.
Thanks @tiago-teixeira5 for the PR!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #536
Inspired #878 , turns out it was missing the
MultiBindingimplementation for theGitLabApiTokenImpl classGitLabApiToken interface.During tests (
mvn verify), there was an unexpected failure onGitLabConnectionConfigTestdue to my machine having port 80 being listened to. Changing the port to an uncommon port (47 is reserved but apparently not assigned) allowed to circumvent that.Testing done
A test was added that runs the full pipeline for testing
withCredentials, binding with both the full$classand thegitlabApiTokenname.Submitter checklist