Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch to using HTMLUnit-compatible JS#1846

Merged
krisstern merged 1 commit into
jenkinsci:masterfrom
daniel-beck:make-htmlunit-work
Dec 9, 2025
Merged

Switch to using HTMLUnit-compatible JS#1846
krisstern merged 1 commit into
jenkinsci:masterfrom
daniel-beck:make-htmlunit-work

Conversation

@daniel-beck

@daniel-beck daniel-beck commented Dec 8, 2025

Copy link
Copy Markdown
Member

Fixes #1845. Amends #1840.

Also applies the suggestion from jenkins-infra/jenkins.io#8584 (comment).

Testing done

Locally interactively; also wrote a test to ensure HTMLUnit doesn't fall over.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@daniel-beck daniel-beck requested a review from a team as a code owner December 8, 2025 20:35
@github-actions github-actions Bot added the tests This PR adds/removes/updates test cases label Dec 8, 2025
MarkEWaite
MarkEWaite approved these changes Dec 9, 2025
View reviewed changes

@MarkEWaite MarkEWaite left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krisstern the plugin BOM release this week will need this to be merged, released, and included in the plugin BOM. Are you willing to do that or would you prefer that I do it?

Refer to plugin BOM issue:

@krisstern

krisstern commented Dec 9, 2025

Copy link
Copy Markdown
Member

Hi @MarkEWaite could you please do the last step this time and show me what is needed for that? I could do the merging of this PR and cutting a new release, but for the BOM part I am not familiar with it.

krisstern
krisstern approved these changes Dec 9, 2025
View reviewed changes

@krisstern krisstern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern merged commit 1afb1d6 into jenkinsci:master Dec 9, 2025
17 checks passed
@MarkEWaite

MarkEWaite commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

I could do the merging of this PR and cutting a new release, but for the BOM part I am not familiar with it.

Once the new release of the GitLab plugin is available, open the "Dependency Updates" page of the plugin BOM, select the Dependabot tab, and choose the "bom-weekly/pom.xml" item and click "Check for updates". That will detect the update and create a pull request that updates the BOM version for the GitLab plugin to the most recent release.

@MarkEWaite MarkEWaite mentioned this pull request Dec 9, 2025
Closed
@daniel-beck daniel-beck deleted the make-htmlunit-work branch December 9, 2025 08:01
@MarkEWaite MarkEWaite mentioned this pull request Dec 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes
@krisstern krisstern krisstern approved these changes

Assignees

No one assigned

Labels

tests This PR adds/removes/updates test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BOM failure with 1.9.11

3 participants

@daniel-beck @krisstern @MarkEWaite