Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix api token rendering#11321

Merged
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
mawinter69:token-styling
Nov 24, 2025
Merged

Fix api token rendering#11321
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
mawinter69:token-styling

Conversation

@mawinter69
Copy link
Copy Markdown
Contributor

@mawinter69 mawinter69 commented Nov 20, 2025

Change #11141 added display: flex with direction column to jenkins-card. This broke the styling of the api token display
This makes the api tokens more independent from jenkins-card

Before:
image

After:
image

Testing done

Interactive testing

Proposed changelog entries

  • Fix api token rendering.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Change jenkinsci#11141 added display: flex with direction column to jenkins-card.
This broke the styling of the api token display
This makes the api-tokens more independent from jenkins-card
@comment-ops-bot comment-ops-bot Bot added the bug For changelog: Minor bug. Will be listed after features label Nov 20, 2025
@NotMyFault NotMyFault requested a review from a team November 21, 2025 07:28
@timja timja requested a review from janfaracik November 21, 2025 12:03
Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Thanks for the fix

@daniel-beck daniel-beck added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Nov 22, 2025
@MarkEWaite
Copy link
Copy Markdown
Contributor

@janfaracik I'd like this fix to be included in the weekly release tomorrow, if that's possible. Could you review it?

@timja
Copy link
Copy Markdown
Member

timja commented Nov 24, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 24, 2025
@MarkEWaite MarkEWaite merged commit 2fa902c into jenkinsci:master Nov 24, 2025
20 checks passed
karthikbhandary2 pushed a commit to karthikbhandary2/jenkins that referenced this pull request Dec 4, 2025
* Fix api token css

Change jenkinsci#11141 added display: flex with direction column to jenkins-card.
This broke the styling of the api token display
This makes the api-tokens more independent from jenkins-card

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants