Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show saved log recorders#23858

Merged
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
timja:log-recorder
Nov 28, 2025
Merged

Show saved log recorders#23858
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
timja:log-recorder

Conversation

@timja
Copy link
Copy Markdown
Member

@timja timja commented Nov 25, 2025

Fixes #23856

Testing done

Created a log recorder and it now shows up again

Proposed changelog entries

  • Show saved log recorders again (regression in 2.537).

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@timja timja mentioned this pull request Nov 25, 2025
14 tasks
@timja timja added bug For changelog: Minor bug. Will be listed after features regression-fix Pull request that fixes a regression in one of the previous Jenkins releases labels Nov 25, 2025
@timja timja requested review from a team and janfaracik November 25, 2025 22:10
@timja timja added the web-ui The PR includes WebUI changes which may need special expertise label Nov 25, 2025
@timja timja requested a review from a team November 26, 2025 09:32
Copy link
Copy Markdown
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in manual testing, both with and without the UI experiment.

(IMO: This particular pattern seems like something that should be solved differently, before it proliferates into plugins.)

@timja
Copy link
Copy Markdown
Member Author

timja commented Nov 26, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 26, 2025
@timja
Copy link
Copy Markdown
Member Author

timja commented Nov 26, 2025

(IMO: This particular pattern seems like something that should be solved differently, before it proliferates into plugins.)

Discussed with Jan, we've got an idea for improving it.
Probably making it a parameter so when its not a management link it can be passed through rather than having to capture, overwrite and restore it

@daniel-beck
Copy link
Copy Markdown
Member

Nice, that aligns with st:include 👍

@MarkEWaite MarkEWaite merged commit 5f529ab into jenkinsci:master Nov 28, 2025
18 checks passed
karthikbhandary2 pushed a commit to karthikbhandary2/jenkins that referenced this pull request Dec 4, 2025
* Show saved log recorders

* Use pattern from rest of settings rework PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jenkins no longer shows log recorders

5 participants