Codestin Search App

janfaracik · 2026-01-02T11:06:23Z

Fixes #16815

What's changed?

Refined interface, feels more cohesive
Validation has been tweaked, using existing Jenkins UI rather than custom stuff
- No longer fires on first focus loss, so you can click a job type without the page throwing an error/shifting focus
- I've also removed changes in focus on the page - it feels quite janky right now as your focus shifts without you realising
'Duplicate a job' UI has been integrated with the list, making it feel less disjointed
The intention is to have this choice list be reusable, e.g. in New View and Credentials plugin
CSS/JS has been simplified

Questions for a follow up PR

Shall we move the Freestyle item down the list (and make Pipelines the top item?)
- Current thoughts are something like this:

Testing done

New items can be created
Existing items can be duplicated
Validation works as expected, submit button disables as expected
ATH/PCT passes

Screenshots (UI changes only)

Before

After

Before

After

Before

After

Proposed changelog entries

Refine the 'New Item' screen

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

The issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

daniel-beck · 2026-01-02T11:09:17Z

tests will be broken, also would like an incremental built for use in Credentials plugin

Broken tests mean no incremental. Edit the pom like https://github.com/jenkinsci/jenkins/pull/9738/files to skip most tests.

timja · 2026-01-04T12:16:44Z

The questions around freestyle make sense but I would do them in a follow up PR, keep this one focused on UI changes

janfaracik · 2026-01-04T12:38:10Z

The questions around freestyle make sense but I would do them in a follow up PR, keep this one focused on UI changes

Agreed. I've also opened a related PR here for Pipelines - jenkinsci/workflow-job-plugin#737

daniel-beck · 2026-01-04T12:40:59Z

How does this interact with the grouping of items in categories (when the flat class is removed in "before")? This should not just be dropped -- it's a longstanding RFE to support item type categories.

These categories are also a vehicle we can use to move e.g., Freestyle and Maven jobs down the list and give greater prominence to other types.

daniel-beck · 2026-01-04T12:41:35Z

The questions around freestyle make sense but I would do them in a follow up PR, keep this one focused on UI changes

Agreed. I've also opened a related PR here for Pipelines - #26031

You're linking to this PR.

daniel-beck · 2026-01-04T12:54:23Z

How does this interact with the grouping of items in categories (when the flat class is removed in "before")? This should not just be dropped -- it's a longstanding RFE to support item type categories.

Noting #26053.

janfaracik · 2026-01-04T12:56:59Z

How does this interact with the grouping of items in categories (when the flat class is removed in "before")? This should not just be dropped -- it's a longstanding RFE to support item type categories.

To simplify JS I've dropped the addition of category headings/descriptions to the DOM. flats been in the codebase for roughly a decade now and AFAIK it's never been used (correct me if I'm wrong?) - personally against keeping it if there isn't an intention to use it.

These categories are also a vehicle we can use to move e.g., Freestyle and Maven jobs down the list and give greater prominence to other types.

This continues to work 👍

You're linking to this PR.

🤦 Fixed - thanks!

daniel-beck · 2026-01-04T13:17:37Z

if there isn't an intention to use it.

Intention is there for me, it's just one of the things on the long list 🤷 Especially once you have a bunch of types, it would make it easier to process the list and find the type you're looking for.

github-actions · 2026-01-07T10:11:31Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

janfaracik · 2026-01-07T16:56:16Z

Intention is there for me, it's just one of the things on the long list 🤷 Especially once you have a bunch of types, it would make it easier to process the list and find the type you're looking for.

I've restored it, if we want to enable it/remove it it can be done so in a followup PR.

daniel-beck · 2026-01-08T11:55:14Z

Thanks! I'll need to play with this a bit, since it now requires code changes before they appear unlike a quick browser edit before.

Is it intentional that the focus border shows when just clicking on an entry? That seems inconsistent with everything else in Jenkins, which doesn't show the border when just clicked.

janfaracik · 2026-01-08T12:16:34Z

Is it intentional that the focus border shows when just clicking on an entry? That seems inconsistent with everything else in Jenkins, which doesn't show the border when just clicked.

Hmm it isn't intentional - what browser are you using? I'm a Safari user, tried it in Chrome and it was fine but I may have broken it since. Will get a fix in when I'm back home from work.

daniel-beck · 2026-01-08T14:30:34Z

This was in Firefox.

daniel-beck · 2026-01-08T14:39:56Z

This works great with categories enabled, thanks.

The last entry to copy an existing item looks a little awkward now, as it appears to be in the last category, but we can leave that to future fine-tuning if we decide to bring back the categories.

OTOH I guess an argument could be made that copying an existing item has no reason to be in the same list, without visual spacing to indicate this is not like the other options, and should be separated visually somehow?

janfaracik · 2026-01-09T10:38:12Z

This was in Firefox.

Should be fixed now - tried Safari/Chrome/Firefox and looks good. Kills me inside that they all handle focus differently however.

OTOH I guess an argument could be made that copying an existing item has no reason to be in the same list, without visual spacing to indicate this is not like the other options, and should be separated visually somehow?

Yeah I can see that argument for sure. I think currently they're too separated, and the 'Copy an existing item' feels disconnected/janky/bit of an afterthought. I prefer them combined right now, but I can see that not working great if they're categorised.

daniel-beck · 2026-01-09T12:00:56Z

Even without categories, "Select an item type" isn't quite what this option does.

WDYT about this? No change to how anything works, just as a visual separator?

531455935-da7be31f-4edb-47f0-803a-27b9ce9c27d2

janfaracik · 2026-01-20T09:30:59Z

Even without categories, "Select an item type" isn't quite what this option does.

WDYT about this? No change to how anything works, just as a visual separator?

Grand, added the separator:

timja

LGTM

For a future enhancement, still poor UX when copying a job. My natural flow is to click copy first and select the job without filling in a name. Tbh I feel like you should be able to copy the job and it creates a temp job with a name based off of the original

timja · 2026-01-27T10:21:20Z

@jenkinsci/sig-ux could someone take a quick look please?

lewisbirks

Looks a lot better, I like that clicking on an item no longer changes the focus

timja · 2026-02-06T16:47:42Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

uhafner · 2026-02-12T09:05:59Z

Is there an update for the ATH available that handles this new page? I get:

org.openqa.selenium.NoSuchElementException: Unable to locate By.cssSelector: li.hudson_model_FreeStyleProject in http://127.0.0.1:45173/newJob
	at org.jenkinsci.test.acceptance.po.CapybaraPortingLayerImpl.find(CapybaraPortingLayerImpl.java:206)
	at org.jenkinsci.test.acceptance.po.JobsMixIn$1.find(JobsMixIn.java:112)
	at org.jenkinsci.test.acceptance.po.JobsMixIn$1.find(JobsMixIn.java:108)
	at org.jenkinsci.test.acceptance.po.CapybaraPortingLayerImpl.findCaption(CapybaraPortingLayerImpl.java:561)
	at org.jenkinsci.test.acceptance.po.JobsMixIn.findTypeCaption(JobsMixIn.java:22)
	at org.jenkinsci.test.acceptance.po.JobsMixIn.create(JobsMixIn.java:29)
	at org.jenkinsci.test.acceptance.po.JobsMixIn.create(JobsMixIn.java:91)
	at io.jenkins.plugins.analysis.warnings.UiTest.createFreeStyleJob(UiTest.java:60)

for all my UI tests that create freestyle jobs.

See jenkinsci/warnings-ng-plugin#3269 and https://github.com/jenkinsci/warnings-ng-plugin/actions/runs/21860108764/job/63086702620?pr=3269

timja · 2026-02-12T09:26:25Z

requires https://github.com/jenkinsci/acceptance-test-harness/releases/tag/6512.v7b_8c43086a_6f

uhafner · 2026-02-12T09:54:46Z

requires https://github.com/jenkinsci/acceptance-test-harness/releases/tag/6512.v7b_8c43086a_6f

I see. It seems that dependabot does not pick the new releases anymore :-(

timja · 2026-02-12T10:05:04Z

Yes dependabot has been broken for a month for the CD release format...

dependabot/dependabot-core#11068 (comment)

dependabot/dependabot-core#14102

Quite a few plugins have switched to renovate instead.

Refine the 'New Item' screen

70f03b4

Simplify SCSS

f8fbdf8

comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 2, 2026

janfaracik added 2 commits January 2, 2026 13:25

Fix submission, fix some tests, improve tabbing + focus states

c818eaa

Fix more tests

9673212

janfaracik mentioned this pull request Jan 2, 2026

New credentials dialog jenkinsci/credentials-plugin#992

Merged

21 tasks

Simplify JS + hopefully fix test

0505b32

janfaracik mentioned this pull request Jan 2, 2026

Refine dialog component #26033

Merged

14 tasks

Update pom.xml

1825401

janfaracik mentioned this pull request Jan 3, 2026

Test 'Refine the 'New Item' screen' jenkinsci/acceptance-test-harness#2572

Merged

6 tasks

janfaracik added needs-ath-build Needs to run through the full acceptance-test-harness suite needs-pct-build A run through of bom is needed labels Jan 3, 2026

janfaracik mentioned this pull request Jan 3, 2026

Test 'Refine the 'New Item' screen' jenkinsci/bom#6178

Closed

6 tasks

Update Jenkinsfile

dc7f320

janfaracik requested a review from a team January 4, 2026 12:12

janfaracik marked this pull request as ready for review January 4, 2026 12:15

janfaracik mentioned this pull request Jan 4, 2026

Move Pipeline to first position in New Item page, adjust item description jenkinsci/workflow-job-plugin#737

Merged

6 tasks

Merge branch 'master' into revamp-new-item

52f14b2

github-actions Bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jan 7, 2026

Restore ability to have headings

71a09cc

janfaracik added 2 commits January 9, 2026 10:32

Fix focus state in Firefox/Chrome

6bbbf06

Merge branch 'master' into revamp-new-item

1192088

timja mentioned this pull request Jan 13, 2026

[JENKINS-76103] Unable to copy from another Job after clicking an item type #16815

Closed

Add separator between items and 'Duplicate an item'

d50d737

janfaracik requested review from daniel-beck and timja January 20, 2026 09:31

timja approved these changes Jan 22, 2026

View reviewed changes

timja requested a review from a team January 23, 2026 14:40

lewisbirks approved these changes Feb 6, 2026

View reviewed changes

comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 6, 2026

MarkEWaite merged commit f972b9d into jenkinsci:master Feb 9, 2026
18 checks passed

ShirayukiRin mentioned this pull request Apr 11, 2026

[JENKINS-76103] fix "Copy from" creates new item instead of copying in Firefox #11090

Closed

14 tasks

Uh oh!

Conversation

janfaracik commented Jan 2, 2026 • edited by timja Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's changed?

Questions for a follow up PR

Testing done

Screenshots (UI changes only)

Proposed changelog entries

Proposed changelog category

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

Uh oh!

daniel-beck commented Jan 2, 2026

Uh oh!

timja commented Jan 4, 2026

Uh oh!

janfaracik commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daniel-beck commented Jan 4, 2026

Uh oh!

daniel-beck commented Jan 4, 2026

Uh oh!

daniel-beck commented Jan 4, 2026

Uh oh!

janfaracik commented Jan 4, 2026

Uh oh!

daniel-beck commented Jan 4, 2026

Uh oh!

github-actions Bot commented Jan 7, 2026

Uh oh!

janfaracik commented Jan 7, 2026

Uh oh!

daniel-beck commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janfaracik commented Jan 8, 2026

Uh oh!

daniel-beck commented Jan 8, 2026

Uh oh!

daniel-beck commented Jan 8, 2026

Uh oh!

janfaracik commented Jan 9, 2026

Uh oh!

daniel-beck commented Jan 9, 2026

Uh oh!

janfaracik commented Jan 20, 2026

Uh oh!

timja left a comment

Choose a reason for hiding this comment

Uh oh!

timja commented Jan 27, 2026

Uh oh!

lewisbirks left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timja commented Feb 6, 2026

Uh oh!

Uh oh!

uhafner commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Feb 12, 2026

Uh oh!

uhafner commented Feb 12, 2026

Uh oh!

timja commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

janfaracik commented Jan 2, 2026 •

edited by timja

Loading

janfaracik commented Jan 4, 2026 •

edited

Loading

daniel-beck commented Jan 8, 2026 •

edited

Loading

lewisbirks left a comment •

edited

Loading

uhafner commented Feb 12, 2026 •

edited

Loading