Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix primary button text color in administrative monitors#26212

Merged
timja merged 1 commit into
jenkinsci:masterfrom
dhanush-raja-a:fix-admin-monitor-button-color
Jan 29, 2026
Merged

Fix primary button text color in administrative monitors#26212
timja merged 1 commit into
jenkinsci:masterfrom
dhanush-raja-a:fix-admin-monitor-button-color

Conversation

@dhanush-raja-a
Copy link
Copy Markdown
Contributor

@dhanush-raja-a dhanush-raja-a commented Jan 28, 2026

Fixes #26205

Testing done

  • Built Jenkins locally
  • Ran Jenkins using mvn -pl war jetty:run
  • Reproduced the issue by rendering an administrative monitor message
  • Verified that primary buttons inside administrative monitors retain correct styling
  • Confirmed button text color is no longer overridden by admin monitor link styles
  • CSS-only change; no Java or Jelly logic modified

Screenshots (UI changes only)

Before

Primary button text inherits alert/link color inside administrative monitor.
Screenshot 2026-01-28 at 10 53 50β€―AM

After

Primary button text is white as expected, with correct primary button styling.
Screenshot 2026-01-28 at 10 53 57β€―AM

Proposed changelog entries

  • Fix primary button text color in administrative monitors.

Proposed changelog category

/label bug, web-ui

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue is well-described.
  • The changelog entry is appropriate and in the imperative mood.
  • There is an explanation as to why this change has no automated tests (CSS-only UI fix).
  • No new public APIs or Java changes were introduced.
  • UI changes do not introduce CSP regressions.
  • No dependency updates are included.

Desired reviewers

@jenkinsci/core-pr-reviewers

@comment-ops-bot comment-ops-bot Bot added bug For changelog: Minor bug. Will be listed after features web-ui The PR includes WebUI changes which may need special expertise labels Jan 28, 2026
@timja timja requested a review from janfaracik January 28, 2026 11:52
Copy link
Copy Markdown
Member

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks!

Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 28, 2026
@timja timja merged commit 0d0e41b into jenkinsci:master Jan 29, 2026
19 checks passed
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 29, 2026

Congratulations on getting your very first Jenkins core pull request merged πŸŽ‰πŸ₯³

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links with jenkins-button class in administrative monitors have wrong color

4 participants