Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not pick up random message Jelly variable in l:keyboard-shortcut#26214

Merged
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
daniel-beck:fix-attrs-message
Jan 29, 2026
Merged

Do not pick up random message Jelly variable in l:keyboard-shortcut#26214
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
daniel-beck:fix-attrs-message

Conversation

@daniel-beck
Copy link
Copy Markdown
Member

Fixes #26213.

Amends #8435, specifically f925849.

Testing done

  1. Navigated to a view that defines message with {…} content and no more exception.

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Fix exception message being logged in rare cases on views with keyboard shortcut indicators.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added the bug For changelog: Minor bug. Will be listed after features label Jan 28, 2026
@timja
Copy link
Copy Markdown
Member

timja commented Jan 28, 2026

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 28, 2026
@MarkEWaite MarkEWaite merged commit 35cf374 into jenkinsci:master Jan 29, 2026
17 checks passed
@daniel-beck daniel-beck deleted the fix-attrs-message branch January 29, 2026 22:01
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Mar 3, 2026
…t` (jenkinsci#26214)

Do not pick up random `message` Jelly variable in l:keyboard-shortcut

Co-authored-by: Daniel Beck <[email protected]>
Co-authored-by: Tim Jacomb <[email protected]>
(cherry picked from commit 35cf374)
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Mar 4, 2026
…t` (jenkinsci#26214)

Do not pick up random `message` Jelly variable in l:keyboard-shortcut

Co-authored-by: Daniel Beck <[email protected]>
Co-authored-by: Tim Jacomb <[email protected]>
(cherry picked from commit 35cf374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception thrown on views setting message variable

4 participants