Do not pick up random message Jelly variable in l:keyboard-shortcut#26214
Merged
Conversation
MarkEWaite
approved these changes
Jan 28, 2026
timja
approved these changes
Jan 28, 2026
Member
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
NotMyFault
approved these changes
Jan 28, 2026
krisstern
pushed a commit
to krisstern/jenkins
that referenced
this pull request
Mar 3, 2026
…t` (jenkinsci#26214) Do not pick up random `message` Jelly variable in l:keyboard-shortcut Co-authored-by: Daniel Beck <[email protected]> Co-authored-by: Tim Jacomb <[email protected]> (cherry picked from commit 35cf374)
krisstern
pushed a commit
to krisstern/jenkins
that referenced
this pull request
Mar 4, 2026
…t` (jenkinsci#26214) Do not pick up random `message` Jelly variable in l:keyboard-shortcut Co-authored-by: Daniel Beck <[email protected]> Co-authored-by: Tim Jacomb <[email protected]> (cherry picked from commit 35cf374)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26213.
Amends #8435, specifically f925849.
Testing done
messagewith{…}content and no more exception.Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.