Hide last repeatable delete button with minimum > 0#26277
Merged
Conversation
When a repeatable has set a minimum > 0 it means there should always be at least one such entry. So showing the delete button in that case when there is only one entry is wrong. Interestingly there is already support for this behaviour with the class `show-if-not-only`. A few plugins used that with the old input based buttons. This change now makes this automatic. The repeated-container gets the value of the passed minimum and the corresponding class is automatically added to all delete buttons in the container.
StefanSpieker
approved these changes
Feb 7, 2026
Contributor
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. /label ready-for-merge |
Member
|
Maybe for another PR, but can the row where that delete button was be removed too? (The empty space above "Repository URL" in your "after" screenshot) |
Contributor
Author
See #23882 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a repeatable has set a minimum > 0 it means there should always be at least one such entry. So showing the delete button in that case when there is only one entry is wrong. Interestingly there is already support for this behaviour with the class
show-if-not-only. A few plugins used that with the old input based buttons.This change now makes this automatic. The repeated-container gets the value of the passed minimum and the corresponding class is automatically added to all delete buttons in the container.
Not sure if I should label this as bug or enhancement. It's kind of both as with the introduction of the
f:repeatableDeleteButtonthat feature was somehow lost/forgotten, but before it was also not automatic. Labelled it for now as rfe.Note that some plugins use the construct
to hide the delete button while using
f:repeatableDeleteButton. This doesn't influence the behaviourTesting done
Test with minimum=1
Test with minimum=0 with a log recorder
Addbutton for LoggersScreenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label rfe,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.