Don't validate input fields when they are disabled#26298
Merged
Conversation
timja
reviewed
Feb 11, 2026
Co-authored-by: Tim Jacomb <[email protected]>
NotMyFault
approved these changes
Feb 13, 2026
janfaracik
approved these changes
Feb 13, 2026
Member
janfaracik
left a comment
There was a problem hiding this comment.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
9 tasks
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Feb 14, 2026
Pull request: * jenkinsci/jenkins#26313 Includes Jenkins core pull requests: * jenkinsci/jenkins#26312 * jenkinsci/jenkins#26311 * jenkinsci/jenkins#26310 * jenkinsci/jenkins#26307 * jenkinsci/jenkins#26305 * jenkinsci/jenkins#26304 * jenkinsci/jenkins#26303 * jenkinsci/jenkins#26302 * jenkinsci/jenkins#26301 * jenkinsci/jenkins#26298 * jenkinsci/jenkins#26295 * jenkinsci/jenkins#26294 * jenkinsci/jenkins#26293 * jenkinsci/jenkins#26291 * jenkinsci/jenkins#26240 * jenkinsci/jenkins#26190 * jenkinsci/jenkins#26188 * jenkinsci/jenkins#26149
5 tasks
MarkEWaite
added a commit
to MarkEWaite/acceptance-test-harness
that referenced
this pull request
Feb 14, 2026
Pull request: * jenkinsci/jenkins#26313 Includes Jenkins core pull requests: * jenkinsci/jenkins#26312 * jenkinsci/jenkins#26311 * jenkinsci/jenkins#26310 * jenkinsci/jenkins#26307 * jenkinsci/jenkins#26305 * jenkinsci/jenkins#26304 * jenkinsci/jenkins#26303 * jenkinsci/jenkins#26302 * jenkinsci/jenkins#26301 * jenkinsci/jenkins#26298 * jenkinsci/jenkins#26295 * jenkinsci/jenkins#26294 * jenkinsci/jenkins#26293 * jenkinsci/jenkins#26291 * jenkinsci/jenkins#26240 * jenkinsci/jenkins#26190 * jenkinsci/jenkins#26188 * jenkinsci/jenkins#26149
5 tasks
meetgoti07
pushed a commit
to meetgoti07/jenkins
that referenced
this pull request
Mar 14, 2026
* Don't validate fields when they are disabled fixes jenkinsci#26297 * Apply suggestions from code review Co-authored-by: Tim Jacomb <[email protected]> --------- Co-authored-by: Tim Jacomb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a problem where disabled checkboxes still call the checkUrl endpoint to validate the field. When that validation throws an exception, e.g. due to missing permissions (user has SYSTEM_READ), the user is redirected to the login page instead of being able to see the corresponding config page.
fixes #26297
Testing done
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.