Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't validate input fields when they are disabled#26298

Merged
timja merged 2 commits into
jenkinsci:masterfrom
mawinter69:disabled-checkbox
Feb 18, 2026
Merged

Don't validate input fields when they are disabled#26298
timja merged 2 commits into
jenkinsci:masterfrom
mawinter69:disabled-checkbox

Conversation

@mawinter69
Copy link
Copy Markdown
Contributor

Fix a problem where disabled checkboxes still call the checkUrl endpoint to validate the field. When that validation throws an exception, e.g. due to missing permissions (user has SYSTEM_READ), the user is redirected to the login page instead of being able to see the corresponding config page.

fixes #26297

Testing done

  1. Install https://plugins.jenkins.io/extended-read-permission/
  2. Configure Jenkins with built-in user database
  3. Install matrix auth plugin and enable it
  4. create and configure a user to have the permissions Overall/Read and Overall/SystemRead
  5. As that user visit Manage Jenkins -> System
  6. The page no longer redirects to login page

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Don't validate input fields when they are disabled

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added the bug For changelog: Minor bug. Will be listed after features label Feb 11, 2026
Comment thread war/src/main/webapp/scripts/hudson-behavior.js Outdated
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

Copy link
Copy Markdown
Member

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 13, 2026
Copy link
Copy Markdown

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timja timja merged commit 9f99431 into jenkinsci:master Feb 18, 2026
18 checks passed
meetgoti07 pushed a commit to meetgoti07/jenkins that referenced this pull request Mar 14, 2026
* Don't validate fields when they are disabled

fixes jenkinsci#26297

* Apply suggestions from code review

Co-authored-by: Tim Jacomb <[email protected]>

---------

Co-authored-by: Tim Jacomb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A disabled checkbox is still running field validation

5 participants