Codestin Search App

janfaracik · 2026-02-16T10:14:12Z

This PR revamps the Clouds page.

Now using the Notice component for empty states
Table has been replaced by the repeatable list component for consistency and predictability

Testing done

Possible to add clouds
Help link works
Install plugins link works
Reordering clouds works
No users of registerSortableTableDragDrop so I've removed it

Screenshots (UI changes only)

Before (no plugins installed)

After (no plugins installed)

Before

After

Before

After

Proposed changelog entries

Revamp Clouds page

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

The issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

timja · 2026-02-16T11:48:25Z

                    title="${app.hasPermission(app.ADMINISTER) ? '%Configure' : '%View Configuration'}"/>
-            <l:delete permission="${app.ADMINISTER}" title="${%Delete Cloud}" message="${%delete.cloud(it.displayName)}" urlPrefix="${url}"/>
            <t:actions />
+            <l:delete permission="${app.ADMINISTER}" title="${%Delete Cloud}" message="${%delete.cloud(it.displayName)}" urlPrefix="${url}"/>


something doesn't seem to be working right.

When I click delete I get this popup (after confirming):

That shouldn't be happening.

I noticed something similar recently on the old page. I think the reason is that the the model-link create buttons and when you click them it looks as if there was a change on the form. Then on the other hand just reordering the clouds didn't lead to a popup when leaving the cloud.

also noticed on the new one, if you reorder the form, save it, and then click new cloud, it shows this popup too

Need to add class ignore-dirty in jumplist.js and the new cloud button

I've added ignore-dirty-panel to the wrapper of the Configure button and overflow button - looks to be working as expected now.

timja · 2026-02-16T11:52:26Z

            <f:bottomButtonBar>
-              <f:submit id="saveButton" value="${%Save}" clazz="jenkins-hidden" />
+              <f:apply value="${%Save}" clazz="jenkins-button--primary" />
            </f:bottomButtonBar>


pre-existing issue but should there be a cancel button?

I'm not too sure - the other pages don't have a cancel button but then their behaviour is a little different.

This reverts commit 3cb2188.

timja

Changes look good now, just needs PCT and ATH

timja

LGTM

mawinter69

Looks good.
One minor point but that was already a problem before is that after changing the order of clouds, one can leave the page without getting notified of unsaved changes. Not sure if that should be considered or not

timja · 2026-02-17T12:59:20Z

Looks good. One minor point but that was already a problem before is that after changing the order of clouds, one can leave the page without getting notified of unsaved changes. Not sure if that should be considered or not

I think its fine

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

Unfortunately, registerSortableTableDragDrop() got removed by this PR: jenkinsci/jenkins#26315 Restored this javascript functionality in a separate static javascript which now gets used in the list of templates instead of reusing the core JS bundle.

Revamp clouds page

8bed7b4

janfaracik requested a review from a team February 16, 2026 10:14

comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Feb 16, 2026

janfaracik marked this pull request as ready for review February 16, 2026 10:23

janfaracik added needs-ath-build Needs to run through the full acceptance-test-harness suite needs-pct-build A run through of bom is needed labels Feb 16, 2026

timja reviewed Feb 16, 2026

View reviewed changes

Comment thread core/src/main/resources/jenkins/agents/CloudSet/index.jelly

timja reviewed Feb 16, 2026

View reviewed changes

Comment thread core/src/main/resources/jenkins/agents/CloudSet/index.jelly

timja reviewed Feb 16, 2026

View reviewed changes

Comment thread core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

janfaracik added 8 commits February 16, 2026 13:47

Update sidepanel.jelly

5135cfa

Update index.jelly

73f4889

Update index.jelly

3cb2188

Update index.jelly

0cf79cf

Update index.jelly

96f1598

Update index.jelly

21450b6

Revert "Update index.jelly"

051821c

This reverts commit 3cb2188.

Hide bottom button bar

1480767

timja reviewed Feb 16, 2026

View reviewed changes

This was referenced Feb 17, 2026

Test 'Revamp Clouds page' jenkinsci/bom#6375

Closed

Test 'Revamp Clouds page' jenkinsci/acceptance-test-harness#2615

Closed

timja added ath-successful This PR has successfully passed the full acceptance-test-harness suite and removed needs-ath-build Needs to run through the full acceptance-test-harness suite labels Feb 17, 2026

janfaracik added pct-successful This PR has successfully passed the full plugin-compatibility-test suite and removed needs-pct-build A run through of bom is needed labels Feb 17, 2026

janfaracik requested review from mawinter69 and timja February 17, 2026 11:04

timja approved these changes Feb 17, 2026

View reviewed changes

mawinter69 approved these changes Feb 17, 2026

View reviewed changes

comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 17, 2026

timja added this pull request to the merge queue Feb 18, 2026

Merged via the queue into jenkinsci:master with commit bc9bf81 Feb 18, 2026
22 checks passed

timja deleted the revamp-clouds-page branch February 18, 2026 14:13

felfert mentioned this pull request Apr 18, 2026

Fix compatibility with jenkins > 2.541.3 jenkinsci/jclouds-plugin#224

Merged

6 tasks

Uh oh!

Conversation

janfaracik commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Screenshots (UI changes only)

Before (no plugins installed)

After (no plugins installed)

Before

After

Before

After

Proposed changelog entries

Proposed changelog category

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

Uh oh!

timja Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mawinter69 Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

timja Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

mawinter69 Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

janfaracik Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

timja Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

janfaracik Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timja left a comment

Choose a reason for hiding this comment

Uh oh!

timja left a comment

Choose a reason for hiding this comment

Uh oh!

mawinter69 left a comment

Choose a reason for hiding this comment

Uh oh!

timja commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

janfaracik commented Feb 16, 2026 •

edited

Loading

timja Feb 16, 2026 •

edited

Loading