Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refine Third Party Licences page#26476

Merged
MarkEWaite merged 5 commits into
jenkinsci:masterfrom
janfaracik:third-party-licences
Mar 21, 2026
Merged

Refine Third Party Licences page#26476
MarkEWaite merged 5 commits into
jenkinsci:masterfrom
janfaracik:third-party-licences

Conversation

@janfaracik
Copy link
Copy Markdown
Member

@janfaracik janfaracik commented Mar 17, 2026

Really small PR to update the Third Party Licences pages to use the experimental Manage Jenkins UI. This page is accessible via About Jenkins -> License and dependency information for plugins.

It probably wouldn't be an enormous amount of work to get the breadcrumbs correct, e.g. Jenkins / Manage Jenkins / About Jenkins / Pipeline Graph View - happy to make that change if deemed necessary. Done, plugin info now sits under About Jenkins.

Testing done

  • UI works as expected in normal/experimental UIs

Screenshots (UI changes only)

Before

image

After (experimental flag disabled)

image

After (experimental flag enabled)

image

Proposed changelog entries

  • Refine Third Party Licences page

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Mar 17, 2026
@timja
Copy link
Copy Markdown
Member

timja commented Mar 17, 2026

Worth a go at getting the breadcrumb right - I get it was broken before though so not a hard requirement.

@janfaracik
Copy link
Copy Markdown
Member Author

Worth a go at getting the breadcrumb right - I get it was broken before though so not a hard requirement.

Done.

Comment thread core/src/main/java/hudson/AboutJenkins.java
Comment thread core/src/main/java/hudson/AboutJenkins.java Outdated
@janfaracik janfaracik requested a review from timja March 19, 2026 09:43
Copy link
Copy Markdown
Contributor

@lewisbirks lewisbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally and it all seems to look fine

Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in my interactive testing. I checked that the behavior was the same for :

  • static resources like ionicons
  • 3rd party dependencies of plugins
  • A breadcrumb for the "About Jenkins" entry in the path to the "About" page for a specific plugin

I explored various other comparisons side by side and found no issues.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

/label ready-for-merge

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 20, 2026
@MarkEWaite MarkEWaite merged commit 3ef4905 into jenkinsci:master Mar 21, 2026
18 checks passed
@janfaracik janfaracik deleted the third-party-licences branch March 21, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants