Refine Third Party Licences page#26476
Conversation
|
Worth a go at getting the breadcrumb right - I get it was broken before though so not a hard requirement. |
Done. |
lewisbirks
left a comment
There was a problem hiding this comment.
Tried it locally and it all seems to look fine
There was a problem hiding this comment.
Looks good in my interactive testing. I checked that the behavior was the same for :
- static resources like ionicons
- 3rd party dependencies of plugins
- A breadcrumb for the "About Jenkins" entry in the path to the "About" page for a specific plugin
I explored various other comparisons side by side and found no issues.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.
/label ready-for-merge
Really small PR to update the Third Party Licences pages to use the experimental Manage Jenkins UI. This page is accessible via About Jenkins -> License and dependency information for plugins.
It probably wouldn't be an enormous amount of work to get the breadcrumbs correct, e.g.Done, plugin info now sits under About Jenkins.Jenkins / Manage Jenkins / About Jenkins / Pipeline Graph View- happy to make that change if deemed necessary.Testing done
Screenshots (UI changes only)
Before
After (experimental flag disabled)
After (experimental flag enabled)
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.