Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refine dialogs#26514

Merged
janfaracik merged 6 commits into
jenkinsci:masterfrom
janfaracik:refine-dialogs
Apr 10, 2026
Merged

Refine dialogs#26514
janfaracik merged 6 commits into
jenkinsci:masterfrom
janfaracik:refine-dialogs

Conversation

@janfaracik
Copy link
Copy Markdown
Member

@janfaracik janfaracik commented Mar 24, 2026

This PR refines the appearance and API of dialogs.

What's changed?

  • Buttons are now full width, increasing hitbox size
  • Bottom app bars sit correctly in dialogs
  • Simplified API - now standardised
  • okText parameter for customising the default button text for confirmation links, adopted in log recorders
    • Default buttons should be descriptive, not generic 'OK/Yes' (needs to be documented in Design Library still)

Testing done

Screenshots (UI changes only)

Before

Screenshot 2026-03-24 at 12 29 10

After

image

Proposed changelog entries

  • Refine appearance of dialogs

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Mar 24, 2026
@janfaracik janfaracik requested a review from mawinter69 March 24, 2026 13:19
@janfaracik janfaracik marked this pull request as ready for review March 24, 2026 13:19
@daniel-beck

This comment was marked as off-topic.

@janfaracik janfaracik requested review from a team and timja March 29, 2026 10:30
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from a team March 31, 2026 20:39
@janfaracik janfaracik requested a review from NotMyFault April 5, 2026 13:09
@janfaracik
Copy link
Copy Markdown
Member Author

Happy with this @mawinter69?

@mawinter69
Copy link
Copy Markdown
Contributor

The buttons become quite wide on larger forms
image

@timja
Copy link
Copy Markdown
Member

timja commented Apr 9, 2026

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 9, 2026
@janfaracik janfaracik merged commit ec9d72d into jenkinsci:master Apr 10, 2026
18 checks passed
@janfaracik janfaracik deleted the refine-dialogs branch April 10, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants