Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refine experimental Run overflow menu#26524

Merged
timja merged 1 commit into
jenkinsci:masterfrom
janfaracik:delay-loading-overflow
Mar 26, 2026
Merged

Refine experimental Run overflow menu#26524
timja merged 1 commit into
jenkinsci:masterfrom
janfaracik:delay-loading-overflow

Conversation

@janfaracik
Copy link
Copy Markdown
Member

This PR refines the recent App Bar API for the Run page.

What's changed?

  • Improved performance (ever so slightly)
    • Instead of loading in overflow menu items immediately, they're now deferred until a user clicks on the button.
  • Some actions weren't showing, such as Embeddable Build Status
    • This was due to a null iconFileName, we now check against IconSpec if implemented
  • Renamed app-bar-controls.jelly to actions.jelly
    • The thinking behind this is that these actions might appear outside of app bars, e.g. inside of tables or cards, and renaming it now future proofs us

Testing done

  • Menu shows
  • Check network tab to confirm it's a separate, deferred call

Screenshots (UI changes only)

Before

Screenshot 2026-03-25 at 14 58 30

After

Screenshot 2026-03-25 at 14 57 01

Proposed changelog entries

  • Refine experimental Run overflow menu

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Mar 25, 2026
@janfaracik janfaracik force-pushed the delay-loading-overflow branch from ae4170c to 86face9 Compare March 25, 2026 15:52
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


they're now deferred until a user clicks on the button

From my testing its actually hover or focus, not click, which is better anyway as its ready for the user and its also only ran once.

@timja
Copy link
Copy Markdown
Member

timja commented Mar 25, 2026

let's proceed as its a trivial one


/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 25, 2026
@timja timja merged commit 6f38482 into jenkinsci:master Mar 26, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants