Refine experimental Run overflow menu#26524
Merged
Merged
Conversation
ae4170c to
86face9
Compare
timja
reviewed
Mar 25, 2026
Member
timja
left a comment
There was a problem hiding this comment.
LGTM
they're now deferred until a user clicks on the button
From my testing its actually hover or focus, not click, which is better anyway as its ready for the user and its also only ran once.
timja
approved these changes
Mar 25, 2026
Member
|
let's proceed as its a trivial one /label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the recent App Bar API for the Run page.
What's changed?
iconFileName, we now check againstIconSpecif implementedapp-bar-controls.jellytoactions.jellyTesting done
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.