Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove lines from log recorder page#26598

Merged
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
janfaracik:remove-lines
Apr 9, 2026
Merged

Remove lines from log recorder page#26598
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
janfaracik:remove-lines

Conversation

@janfaracik
Copy link
Copy Markdown
Member

@janfaracik janfaracik commented Apr 8, 2026

This PR fixes a small visual bug where there are lines on the log recorder page. I believe there was an issue for this but for the life of me I can't find it.

Testing done

  • Lines have been removed

Screenshots (UI changes only)

Before

image

After

image

Proposed changelog entries

  • Remove lines from log recorder page.

Proposed changelog category

/label web-ui, bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features labels Apr 8, 2026
@janfaracik janfaracik marked this pull request as ready for review April 8, 2026 08:13
@daniel-beck
Copy link
Copy Markdown
Member

daniel-beck commented Apr 8, 2026

I believe there was an issue for this but for the life of me I can't find it.

I am aware of a Nov 21-22 2025 conversation in the ux-sig channel. Maybe that?

@MarkEWaite MarkEWaite requested a review from Copilot April 8, 2026 13:05
Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I confirmed it is working as expected by running a local copy of the pull request.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

/label ready-for-merge

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts core SCSS styling for the log recorder UI to remove unwanted dividing lines by moving the border from the individual <pre> blocks to the wrapping container.

Changes:

  • Add a single border to .logrecord-container and remove borders from contained <pre> elements.
  • Add an :empty rule intended to hide the container when it has no content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}
}

&:empty {
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:empty will not reliably match .logrecord-container when there are no log records, because logRecords.jelly emits whitespace/newlines inside the <div> (whitespace counts as a text node, so the element is not :empty). As a result, the container may still render (including the border) even when there are no <pre> children. Consider either rendering the container only when there are records (preferred), or switching to a selector that checks for the presence of <pre> elements instead of :empty (bearing in mind browser support).

Suggested change
&:empty {
&:not(:has(pre)) {

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't true in my (brief) testing. The border was visible with no children, adding :empty hid it.

@MarkEWaite MarkEWaite merged commit 1e98bb7 into jenkinsci:master Apr 9, 2026
22 checks passed
@janfaracik janfaracik deleted the remove-lines branch April 9, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants