Remove lines from log recorder page#26598
Conversation
I am aware of a Nov 21-22 2025 conversation in the ux-sig channel. Maybe that? |
MarkEWaite
left a comment
There was a problem hiding this comment.
Thanks! I confirmed it is working as expected by running a local copy of the pull request.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.
/label ready-for-merge
There was a problem hiding this comment.
Pull request overview
This PR adjusts core SCSS styling for the log recorder UI to remove unwanted dividing lines by moving the border from the individual <pre> blocks to the wrapping container.
Changes:
- Add a single border to
.logrecord-containerand remove borders from contained<pre>elements. - Add an
:emptyrule intended to hide the container when it has no content.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| } | ||
|
|
||
| &:empty { |
There was a problem hiding this comment.
:empty will not reliably match .logrecord-container when there are no log records, because logRecords.jelly emits whitespace/newlines inside the <div> (whitespace counts as a text node, so the element is not :empty). As a result, the container may still render (including the border) even when there are no <pre> children. Consider either rendering the container only when there are records (preferred), or switching to a selector that checks for the presence of <pre> elements instead of :empty (bearing in mind browser support).
| &:empty { | |
| &:not(:has(pre)) { |
There was a problem hiding this comment.
This isn't true in my (brief) testing. The border was visible with no children, adding :empty hid it.
This PR fixes a small visual bug where there are lines on the log recorder page. I believe there was an issue for this but for the life of me I can't find it.
Testing done
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label web-ui, bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.