Use correct views tabbar in new dashboard page respecting user preferences#26640
Merged
Conversation
The new dashboard page always used the views tabbar defined on the container ignoring the user preferences. And the path j:when to detect the myviews proeprty was comparing against the view class and not the owner so that always evaluated to false
mawinter69
commented
Apr 14, 2026
| <j:choose> | ||
| <j:when test="${view.class.name eq 'hudson.model.MyViewsProperty'}"> | ||
| <st:include page="viewTabs" it="${view.owner.userViewsTabBar}" /> | ||
| <j:when test="${view.owner.class.name eq 'hudson.model.MyViewsProperty'}"> |
Contributor
Author
There was a problem hiding this comment.
That condition was always false as it compared the view class instead of the owner class
| </j:when> | ||
| <j:otherwise> | ||
| <st:include page="viewTabs" it="${view.owner.viewsTabBar}" /> | ||
| <st:include page="viewTabs" it="${view.owner.userViewsTabBar}" /> |
Contributor
Author
There was a problem hiding this comment.
That ignored the user preferences
utafrali
approved these changes
Apr 14, 2026
utafrali
left a comment
There was a problem hiding this comment.
Two real bugs fixed and confirmed working via before/after screenshots: the condition was comparing the wrong object's class (view vs. view.owner), and the two tabbar references in the branches were swapped. The fix is correct; the main gap is that the PR description only describes the condition bug, leaving the branch swap unexplained.
timja
approved these changes
Apr 15, 2026
Member
timja
left a comment
There was a problem hiding this comment.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new dashboard page always used the views tabbar defined on the container ignoring the user preferences. And the path
j:whento detect the myviews property was comparing against the view class and not the owner so that always evaluated to falseTesting done
Favorite Viewfor Default Views Tab BarScreenshots (UI changes only)
With Favorite View plugin installed, selected in user preferences and one view marked as favorite, global configuration set to default views tabbar
Before
After
Proposed changelog entries
Proposed changelog category
/label bug,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.