Fix off-by-one error when calculating popup panel dimensions#5312
Open
stefanhaller wants to merge 3 commits intomasterfrom
Open
Fix off-by-one error when calculating popup panel dimensions#5312stefanhaller wants to merge 3 commits intomasterfrom
stefanhaller wants to merge 3 commits intomasterfrom
Conversation
The symptom of the bug was that confirmation panels with wrapped text were one character too wide, which could sometimes result in them being one line too heigh. One concrete example is the "Discard file changes" confirmation that appears when pressing `d` in the commit files panel. I got very confused when investigating this bug, and the reason is that getPopupPanelDimensionsAux took two parameters panelWidth and panelHeight, but the second was actually contentHeight. Rename it to contentHeight, and change the first one to also be the content width rather than the panel width. This is easier for clients, and less confusing.
I got confused when I investigated the bug that was fixed in the previous commit, so hopefully these will be helpful for the next person reading this code.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
fa6f3ea to
1b6c3ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symptom of the bug was that confirmation panels with wrapped text were one character too wide, which could sometimes result in them being one line too heigh. One concrete example is the "Discard file changes" confirmation that appears when pressing
din the commit files panel.