Undersocre support for numbers (set default base for strconv.Parse* to 0) #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabeken
referenced
this pull request
in nabeken/psadm
Jun 17, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/jessevdk/go-flags](https://togithub.com/jessevdk/go-flags) | require | minor | `v1.5.0` -> `v1.6.1` | --- ### Release Notes <details> <summary>jessevdk/go-flags (github.com/jessevdk/go-flags)</summary> ### [`v1.6.1`](https://togithub.com/jessevdk/go-flags/releases/tag/v1.6.1) [Compare Source](https://togithub.com/jessevdk/go-flags/compare/v1.6.0...v1.6.1) **Full Changelog**: jessevdk/go-flags@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/jessevdk/go-flags/releases/tag/v1.6.0) [Compare Source](https://togithub.com/jessevdk/go-flags/compare/v1.5.0...v1.6.0) #### What's Changed - ini: fix IniParser.write() for zero values by [@​sean-](https://togithub.com/sean-) in [https://github.com/jessevdk/go-flags/pull/332](https://togithub.com/jessevdk/go-flags/pull/332) - fix a panic when generating help while the subcommand and all option groups are hidden by [@​bboozzoo](https://togithub.com/bboozzoo) in [https://github.com/jessevdk/go-flags/pull/354](https://togithub.com/jessevdk/go-flags/pull/354) - Help for positional args without allcmd.ArgsRequired dependent from arg.Required by [@​sv99](https://togithub.com/sv99) in [https://github.com/jessevdk/go-flags/pull/342](https://togithub.com/jessevdk/go-flags/pull/342) - Bump golang.org/x/sys from 0.0.0-20210320140829-1e4c9ba3b0c4 to 0.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jessevdk/go-flags/pull/396](https://togithub.com/jessevdk/go-flags/pull/396) - Option to allow passing value to bool flag by [@​alexcb](https://togithub.com/alexcb) in [https://github.com/jessevdk/go-flags/pull/367](https://togithub.com/jessevdk/go-flags/pull/367) - Add support for SOURCE_DATE_EPOCH for TestMan by [@​anthonyfok](https://togithub.com/anthonyfok) in [https://github.com/jessevdk/go-flags/pull/376](https://togithub.com/jessevdk/go-flags/pull/376) - Update to run go-flags on AIX by [@​llrocha](https://togithub.com/llrocha) in [https://github.com/jessevdk/go-flags/pull/390](https://togithub.com/jessevdk/go-flags/pull/390) - Add option for key value delimiter by [@​anaprimawaty](https://togithub.com/anaprimawaty) in [https://github.com/jessevdk/go-flags/pull/392](https://togithub.com/jessevdk/go-flags/pull/392) - Undersocre support for numbers (set default base for strconv.Parse\* to 0) by [@​GRbit](https://togithub.com/GRbit) in [https://github.com/jessevdk/go-flags/pull/404](https://togithub.com/jessevdk/go-flags/pull/404) - docs: add ENV variable usage example by [@​cemremengu](https://togithub.com/cemremengu) in [https://github.com/jessevdk/go-flags/pull/371](https://togithub.com/jessevdk/go-flags/pull/371) - Support per-command PassAfterNonOption by [@​woky](https://togithub.com/woky) in [https://github.com/jessevdk/go-flags/pull/393](https://togithub.com/jessevdk/go-flags/pull/393) - Upgrade by [@​jessevdk](https://togithub.com/jessevdk) in [https://github.com/jessevdk/go-flags/pull/406](https://togithub.com/jessevdk/go-flags/pull/406) #### New Contributors - [@​sean-](https://togithub.com/sean-) made their first contribution in [https://github.com/jessevdk/go-flags/pull/332](https://togithub.com/jessevdk/go-flags/pull/332) - [@​sv99](https://togithub.com/sv99) made their first contribution in [https://github.com/jessevdk/go-flags/pull/342](https://togithub.com/jessevdk/go-flags/pull/342) - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/jessevdk/go-flags/pull/396](https://togithub.com/jessevdk/go-flags/pull/396) - [@​alexcb](https://togithub.com/alexcb) made their first contribution in [https://github.com/jessevdk/go-flags/pull/367](https://togithub.com/jessevdk/go-flags/pull/367) - [@​anthonyfok](https://togithub.com/anthonyfok) made their first contribution in [https://github.com/jessevdk/go-flags/pull/376](https://togithub.com/jessevdk/go-flags/pull/376) - [@​llrocha](https://togithub.com/llrocha) made their first contribution in [https://github.com/jessevdk/go-flags/pull/390](https://togithub.com/jessevdk/go-flags/pull/390) - [@​anaprimawaty](https://togithub.com/anaprimawaty) made their first contribution in [https://github.com/jessevdk/go-flags/pull/392](https://togithub.com/jessevdk/go-flags/pull/392) - [@​GRbit](https://togithub.com/GRbit) made their first contribution in [https://github.com/jessevdk/go-flags/pull/404](https://togithub.com/jessevdk/go-flags/pull/404) - [@​cemremengu](https://togithub.com/cemremengu) made their first contribution in [https://github.com/jessevdk/go-flags/pull/371](https://togithub.com/jessevdk/go-flags/pull/371) - [@​woky](https://togithub.com/woky) made their first contribution in [https://github.com/jessevdk/go-flags/pull/393](https://togithub.com/jessevdk/go-flags/pull/393) **Full Changelog**: jessevdk/go-flags@v1.5.0...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MDIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQwMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, dear @jessevdk! Thank you very much for the library you've built, I'm using it a lot and I enjoy it.
I want to suggest a little improvement for numbers parsing.
Default values in annotations are sometimes quite big, and it would be great to support settings them with underscores like this:
Default library has support for underscores, but it's a bit vague, you need to set the base to 0. That'll also lead to auto-detecting of the base, which is also nice.
An alternative option is to use
strings.ReplaceAll(s, "_", "")which will work, but I prefer to rely on the standard library.Looking forward to knowing what you think, feel free to request any changes or to make changes yourself.