Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: requireAndTranspileModule support ESM #11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 2, 2021
Merged

feat: requireAndTranspileModule support ESM #11232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
28b88d8
refactor(jest-util): add applyInteropRequireDefault option in require…
WeiAnAn Mar 23, 2021
adf5307
refactor(jest-transform): requireAndTranspileModule support ESM
WeiAnAn Mar 23, 2021
6469e42
add esm runner e2e test
WeiAnAn Mar 23, 2021
2ef8e02
move transform-esm-runner test
WeiAnAn Mar 23, 2021
9a394bd
add esm testrunner e2e test
WeiAnAn Mar 23, 2021
5c0f7f3
add esm globalSetup e2e test
WeiAnAn Mar 24, 2021
2f5098d
add esm globalTeardown e2e test
WeiAnAn Mar 24, 2021
409340e
fix esm can not get cjs named export problem
WeiAnAn Mar 28, 2021
8910f9d
update changelog
WeiAnAn Mar 28, 2021
99ce250
remove mutex in runner
WeiAnAn Apr 4, 2021
ed3b8c3
remove eslint comment
WeiAnAn Apr 4, 2021
739a122
add comment on supportsDynamicImport
WeiAnAn Apr 4, 2021
02a697a
clean up temp dir after test
WeiAnAn May 1, 2021
7b721f1
Remove implementation detail in CHANGELOG
WeiAnAn May 2, 2021
a80b820
Remove implementation detail in CHANGELOG
WeiAnAn May 2, 2021
884c7e0
remove redundant test
WeiAnAn May 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix esm can not get cjs named export problem
  • Loading branch information
@WeiAnAn
WeiAnAn committed May 1, 2021
commit 409340e1cc651d2f6ce247a7b573c2f170dbf210
4 changes: 3 additions & 1 deletion e2e/esm-global-setup/setup.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import crypto from 'crypto';
import os from 'os';
import path from 'path';
import fs from 'graceful-fs';
import {createDirectory} from 'jest-util';
import jestUtil from 'jest-util';

const {createDirectory} = jestUtil;

const DIR = path.join(os.tmpdir(), 'jest-esm-global-setup');

Expand Down
4 changes: 3 additions & 1 deletion e2e/esm-global-teardown/teardown.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import crypto from 'crypto';
import os from 'os';
import path from 'path';
import fs from 'graceful-fs';
import {createDirectory} from 'jest-util';
import jestUtil from 'jest-util';

const {createDirectory} = jestUtil;

const DIR = path.join(os.tmpdir(), 'jest-esm-global-teardown');

Expand Down
4 changes: 3 additions & 1 deletion e2e/transform/transform-esm-runner/runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
*/

import throat from 'throat';
import {createEmptyTestResult} from '@jest/test-result';
import testResult from '@jest/test-result';

const {createEmptyTestResult} = testResult;
Comment on lines +8 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import testResult from '@jest/test-result';
const {createEmptyTestResult} = testResult;
import {createEmptyTestResult} from '@jest/test-result';

does this work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
Because ts will compile to common js modules, and export using Object.defineProperty with getter.
ESM named import from CJS module only support exports.name = value way. esm commonjs namespaces

CI error log

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It worked.


export default class BaseTestRunner {
constructor(globalConfig, context) {
Expand Down
4 changes: 3 additions & 1 deletion e2e/transform/transform-esm-testrunner/test-runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
import {createEmptyTestResult} from '@jest/test-result';
import testResult from '@jest/test-result';

const {createEmptyTestResult} = testResult;

export default async function testRunner(
globalConfig,
Expand Down