Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: Update --listTests docs to reflect what it does #12612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2022
Merged

docs: Update --listTests docs to reflect what it does #12612

merged 2 commits into from
Apr 14, 2022

Conversation

Gerrit0
Copy link
Contributor

@Gerrit0 Gerrit0 commented Mar 27, 2022

Summary

The description of --listTests on the website currently implies that --listTests will give output describing all tests as JSON. However, when trying to use it, I found that it did not do this, instead only printing out all test files, one per line. (If also given --json Jest produces JSON, but not by default)

Test plan

N/A

@facebook-github-bot
Copy link
Contributor

Hi @Gerrit0!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you update the versioned docs as well?

@Gerrit0
Copy link
Contributor Author

Gerrit0 commented Apr 1, 2022

By that do you mean for the other folders under website? The file I changed is under versioned docs...

@SimenB
Copy link
Member

SimenB commented Apr 4, 2022

All the versions of this document, yes 🙂

image

@Gerrit0 Gerrit0 requested a review from SimenB April 9, 2022 18:08
SimenB
SimenB approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 1cce9a7 into jestjs:main Apr 14, 2022
@Gerrit0 Gerrit0 deleted the patch-1 branch April 14, 2022 12:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gerrit0 @facebook-github-bot @SimenB