Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(jest-haste-map): Make watchman existence check lazy+async #12675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2022
+87 −22
Merged

fix(jest-haste-map): Make watchman existence check lazy+async #12675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c05f304
fix(jest-haste-map): Lazy+async watchman existence check
robhogan Apr 15, 2022
4da77b3
Cover isWatchmanInstalled behaviour with tests
robhogan Apr 15, 2022
fba23e5
Update CHANGELOG
robhogan Apr 15, 2022
04c6eb3
Lint fixes
robhogan Apr 15, 2022
663bfac
Use "Facebook" copyright headers
robhogan Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint fixes
  • Loading branch information
@robhogan
robhogan committed Apr 15, 2022
commit 04c6eb34ff037e9259d48cc6acc591dcc01a9f14
2 changes: 1 addition & 1 deletion packages/jest-haste-map/src/lib/__tests__/isWatchmanInstalled.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

import isWatchmanInstalled from '../isWatchmanInstalled';
import {execFile} from 'child_process';
import isWatchmanInstalled from '../isWatchmanInstalled';

jest.mock('child_process');

Expand Down
2 changes: 1 addition & 1 deletion packages/jest-haste-map/src/lib/isWatchmanInstalled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import {execFile} from 'child_process';
import {promisify} from 'util';

export default async function isWatchmanInstalled() {
export default async function isWatchmanInstalled(): Promise<boolean> {
try {
await promisify(execFile)('watchman', ['--version']);
return true;
Expand Down