Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(@jest/reporters): improve annotation formatting of GitHubActionsReporter #12826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 9, 2022
Merged

refactor(@jest/reporters): improve annotation formatting of GitHubActionsReporter #12826

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d71c5c1
refactor(@jest/reporters): improve annotations
mrazauskas May 8, 2022
814db33
check paths
mrazauskas May 8, 2022
7c116a7
remove @actions/core
mrazauskas May 8, 2022
ae036a7
relative?
mrazauskas May 8, 2022
e6c5d54
slash and done?
mrazauskas May 8, 2022
300e7eb
remove examples
mrazauskas May 8, 2022
e594bcb
clean up
mrazauskas May 8, 2022
fadd5f2
add change log entry
mrazauskas May 8, 2022
1022130
remove snap
mrazauskas May 8, 2022
172a41e
Restart CI
mrazauskas May 8, 2022
f1a1e97
handle more paths
mrazauskas May 9, 2022
e95b5e5
fix ansi
mrazauskas May 9, 2022
ebd0bf8
fix filename
mrazauskas May 9, 2022
7171272
clean up
mrazauskas May 9, 2022
cc02d0b
Restart CI
mrazauskas May 9, 2022
87fb028
annotate retried tests
mrazauskas May 9, 2022
74c3f74
rootDir again
mrazauskas May 9, 2022
8f60aa1
use rootDir
mrazauskas May 9, 2022
8e6e9ef
log retries first
mrazauskas May 9, 2022
fe273cd
unit test
mrazauskas May 9, 2022
40b847d
reshape
mrazauskas May 9, 2022
a5ac9e0
clean up
mrazauskas May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix filename
  • Loading branch information
@mrazauskas
mrazauskas committed May 9, 2022
commit ebd0bf8818292e4eedcbb2ec63520d596383f1de
6 changes: 3 additions & 3 deletions packages/jest-reporters/src/GitHubActionsReporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default class GitHubActionsReporter extends BaseReporter {
static readonly filename = __filename;

override onTestCaseResult(
test: Test,
_test: Test,
{failureMessages, ancestorTitles, title}: TestCaseResult,
): void {
failureMessages.forEach(failureMessage => {
Expand All @@ -38,14 +38,14 @@ export default class GitHubActionsReporter extends BaseReporter {
);

this.log(
`\n::error file=${test.path},line=${topFrame?.line},title=${errorTitle}::${errorMessage}`,
`\n::error file=${topFrame?.file},line=${topFrame?.line},title=${errorTitle}::${errorMessage}`,
);
});
}
}

// copied from: https://github.com/actions/toolkit/blob/main/packages/core/src/command.ts
function normalizeMessage(input: string): string {
// copied from: https://github.com/actions/toolkit/blob/main/packages/core/src/command.ts
const normalizedInput = input
.replace(/%/g, '%25')
.replace(/\r/g, '%0D')
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-reporters/src/__tests__/__snapshots__/GitHubActionsReporter.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`passes test case report to '@actions/core' when a test has reference error 1`] = `
Array [
"
::error file=/user/project/__tests__/example.test.js:25:12,line=25,title=some test::ReferenceError: abc is not defined%0A%0A at Object.abc (__tests__/example.test.js:25:12)
::error file=/user/project/__tests__/example.test.js,line=25,title=some test::ReferenceError: abc is not defined%0A%0A at Object.abc (__tests__/example.test.js:25:12)
",
]
`;
Expand Down