Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(expect-util): fix comparison of DataView #14408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 20, 2023
Merged

fix(expect-util): fix comparison of DataView #14408

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02c92f3
fix(expect-util): DataView comparison does not work
Dunqing Aug 14, 2023
4b083db
refactoring: reimplementation, never use `as`.
Dunqing Aug 14, 2023
c201c66
feat: improve
Dunqing Aug 14, 2023
37ca34c
Merge branch 'main' into fix/expect-util/dataview
SimenB Sep 20, 2023
3257475
changelog
SimenB Sep 20, 2023
a280fd2
Merge branch 'main' into fix/expect-util/dataview
SimenB Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: improve
  • Loading branch information
@Dunqing
Dunqing committed Aug 14, 2023
commit c201c66a1a83c261ff49a32c5e7fc694fa1b5a83
26 changes: 13 additions & 13 deletions packages/expect-utils/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,23 +398,23 @@ export const arrayBufferEquality = (
dataViewB = new DataView(b);
}

if (dataViewA instanceof DataView && dataViewB instanceof DataView) {
// Buffers are not equal when they do not have the same byte length
if (dataViewA.byteLength !== dataViewB.byteLength) {
return false;
}
if (!(dataViewA instanceof DataView && dataViewB instanceof DataView)) {
return undefined;
}

// Check if every byte value is equal to each other
for (let i = 0; i < dataViewA.byteLength; i++) {
if (dataViewA.getUint8(i) !== dataViewB.getUint8(i)) {
return false;
}
}
// Buffers are not equal when they do not have the same byte length
if (dataViewA.byteLength !== dataViewB.byteLength) {
return false;
}

return true;
// Check if every byte value is equal to each other
for (let i = 0; i < dataViewA.byteLength; i++) {
if (dataViewA.getUint8(i) !== dataViewB.getUint8(i)) {
return false;
}
}

return undefined;
return true;
};

export const sparseArrayEquality = (
Expand Down