Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore!: drop support for Node.js 21#15118

Merged
SimenB merged 3 commits into
jestjs:mainfrom
mrazauskas:drop-nodejs-21
Jul 12, 2024
Merged

chore!: drop support for Node.js 21#15118
SimenB merged 3 commits into
jestjs:mainfrom
mrazauskas:drop-nodejs-21

Conversation

@mrazauskas
Copy link
Copy Markdown
Contributor

@mrazauskas mrazauskas commented Jun 10, 2024

Summary

Perhaps it is time to drop Node.js 21? It is end-of-life since 2024-06-01. Reference: https://github.com/nodejs/Release

Test plan

Green CI.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 10, 2024 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4a247ef
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6667f32139e1c40008269226
😎 Deploy Preview https://deploy-preview-15118--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mrazauskas
mrazauskas commented Jun 10, 2024
View reviewed changes
Comment thread e2e/__tests__/wrongEnv.test.ts

onNodeVersions('<21', () => {
// Node.js 18 is the last LTS version, which is missing the global 'navigator'
onNodeVersions('<=18', () => {
Copy link
Copy Markdown
Contributor Author

@mrazauskas mrazauskas Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will be obsolete after dropping Node.js 18. So I though, perhaps keeping 18 here makes it easier to notice that?

@mrazauskas
Copy link
Copy Markdown
Contributor Author

mrazauskas commented Jun 10, 2024

@SimenB Could you take a look, please? GHA is waiting for status checks on Node v21.x, because these are marked as required. Not so easy to remove them (;

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jul 12, 2024

Not sure about this. It would mean people supporting >=20 wouldn't be able to use Jest. Same technically applies to >=18 already as we've dropped 19, so maybe not a big deal? And as long as we do support 18 (and 16 for that matter), the likelihood of those breaking are low.

So yeah, I think I convinved myself 😀

@SimenB SimenB merged commit 697ce45 into jestjs:main Jul 12, 2024
@mrazauskas mrazauskas deleted the drop-nodejs-21 branch July 12, 2024 08:40
@mrazauskas
Copy link
Copy Markdown
Contributor Author

mrazauskas commented Jul 12, 2024

I think that is fine, since Node.js does not recommend the odd versions for production anyways. Play with it, have fun, but that is it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 12, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrazauskas @SimenB