Codestin Search App

JounQin · 2025-07-06T17:08:15Z

Summary

Remove jest-pnp-resolver

Test plan

netlify · 2025-07-06T17:08:21Z

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`de1f930`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/686ab58e89104a0008317520
😎 Deploy Preview	https://deploy-preview-15721--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2025-07-06T17:13:24Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15721

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15721

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15721

create-jest

npm i https://pkg.pr.new/create-jest@15721

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15721

expect

npm i https://pkg.pr.new/expect@15721

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15721

jest

npm i https://pkg.pr.new/jest@15721

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15721

jest-circus

npm i https://pkg.pr.new/jest-circus@15721

jest-cli

npm i https://pkg.pr.new/jest-cli@15721

jest-config

npm i https://pkg.pr.new/jest-config@15721

@jest/console

npm i https://pkg.pr.new/@jest/console@15721

@jest/core

npm i https://pkg.pr.new/@jest/core@15721

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15721

jest-diff

npm i https://pkg.pr.new/jest-diff@15721

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15721

jest-each

npm i https://pkg.pr.new/jest-each@15721

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15721

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15721

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15721

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15721

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15721

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15721

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15721

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15721

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15721

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15721

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15721

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15721

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15721

jest-mock

npm i https://pkg.pr.new/jest-mock@15721

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15721

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15721

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15721

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15721

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15721

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15721

jest-runner

npm i https://pkg.pr.new/jest-runner@15721

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15721

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15721

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15721

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15721

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15721

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15721

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15721

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15721

@jest/types

npm i https://pkg.pr.new/@jest/types@15721

jest-util

npm i https://pkg.pr.new/jest-util@15721

jest-validate

npm i https://pkg.pr.new/jest-validate@15721

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15721

jest-worker

npm i https://pkg.pr.new/jest-worker@15721

pretty-format

npm i https://pkg.pr.new/pretty-format@15721

commit: 9537d56

JounQin · 2025-07-06T17:29:02Z


 enableGlobalCache: true

+enableTelemetry: false


It slows every yarn related command.

Copilot

Pull Request Overview

This PR removes the legacy PnP resolver, bumps unrs-resolver to v1.11.0, and cleans up associated code and configurations.

Remove jest-pnp-resolver import, PnP branch, and file:// URL handling in defaultResolver.ts
Bump dependency unrs-resolver to ^1.11.0 and drop jest-pnp-resolver in package.json
Update e2e test expectations, snapshots, changelog, and disable telemetry in .yarnrc.yml

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/jest-resolve/src/defaultResolver.ts	Dropped PnP and file URL handling, updated builtins comment
packages/jest-resolve/package.json	Removed `jest-pnp-resolver`, bumped `unrs-resolver` to 1.11.0
e2e/pnp/tests/undeclared-dependency.test.js	Changed thrown message expectation
e2e/tests snapshots	Updated line numbers in snapshots due to code removal
CHANGELOG.md	Added feature entry for resolver bump
.yarnrc.yml	Set `enableTelemetry: false`

Comments suppressed due to low confidence (1)

JounQin · 2025-07-06T17:58:59Z

@cpojer @SimenB Is that possible to give me write permission on this repo or org so that I don't need to fork the repository anymore?

cpojer · 2025-07-09T15:01:22Z

I gave you access, but please still use a fork for PRs as is common.

JounQin · 2025-07-10T07:39:50Z

OK, that's fine.

SimenB · 2025-07-11T11:03:38Z

  expect(() => {
    require('undeclared');
-  }).toThrow(expect.objectContaining({code: 'MODULE_NOT_FOUND'}));
+  }).toThrow("Cannot find module 'unesitent_module__'");


Why no longer error code? And where does unesitent_module__ (typo and all) come from?

jest/e2e/pnp/undeclared-dependency/index.js

Line 9 in 6c6edd8

const nope = require('unesitent_module__');

The error message comes from unrs-resolver if this PR merged, and it comes from jest-pnp-resolver before.

cpojer · 2025-07-27T02:17:37Z

@JounQin what's the status of this PR?

JounQin · 2025-07-27T08:33:13Z

@cpojer The windows compatibility issue has not been resolved: yarnpkg/pnp-rs#10 although the test cases are all passed currently here.

tyadeola · 2025-09-05T17:37:18Z

Summary

Remove Sirdennis-jest

Test plan

SimenB · 2026-05-04T08:01:43Z

Upstream PR landed - could this be rebased and land now?

netlify · 2026-05-19T04:00:39Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`3f8f664`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/6a0c01253d925c0008a9183a
😎 Deploy Preview	https://deploy-preview-15721--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

SimenB

thanks! nice cleanup 🙂

JounQin marked this pull request as draft July 6, 2025 17:18

JounQin force-pushed the chore/bump_unrs-resolver branch from b1d5c47 to 8359d08 Compare July 6, 2025 17:26

JounQin commented Jul 6, 2025

View reviewed changes

JounQin changed the title ~~chore: bump unrs-resolver to 1.11.0, remove unnecessary checks~~ chore: bump unrs-resolver to 1.11.0, remove jest-pnp-resolver and unnecessary checks Jul 6, 2025

JounQin marked this pull request as ready for review July 6, 2025 17:42

JounQin requested review from SimenB, Copilot and cpojer July 6, 2025 17:56

Copilot AI reviewed Jul 6, 2025

View reviewed changes

Comment thread e2e/pnp/__tests__/undeclared-dependency.test.js Outdated

JounQin marked this pull request as draft July 7, 2025 13:57

lesleydreyer mentioned this pull request Jul 8, 2025

[Bug]: Jest w/pnp - using a dep's index.js instead of index.mjs file #15726

Closed

SimenB reviewed Jul 11, 2025

View reviewed changes

hainenber mentioned this pull request Jan 16, 2026

fix(jest-config): support custom reporters in legacy module path $HOME/.node_libraries #15852

Closed

just-small-potato mentioned this pull request Feb 15, 2026

[Bug]: Jest v30: setupFilesAfterEnv fails with mounted volume path (unrs-resolver unsupported construct) #15923

Open

chore: bump unrs-resolver to 1.11.0, remove unnecessary checks

bef8d7b

JounQin force-pushed the chore/bump_unrs-resolver branch from de1f930 to 10e678a Compare May 19, 2026 04:00

JounQin marked this pull request as ready for review May 19, 2026 04:01

JounQin changed the title ~~chore: bump unrs-resolver to 1.11.0, remove jest-pnp-resolver and unnecessary checks~~ chore: bump unrs-resolver to 1.12.1, remove jest-pnp-resolver and unnecessary checks May 19, 2026

JounQin force-pushed the chore/bump_unrs-resolver branch from 10e678a to 0e450ba Compare May 19, 2026 04:12

docs: add related changelog

9537d56

JounQin force-pushed the chore/bump_unrs-resolver branch from 0e450ba to 9537d56 Compare May 19, 2026 04:20

JounQin requested review from SimenB and Copilot May 19, 2026 04:51

Copilot started reviewing on behalf of JounQin May 19, 2026 04:51 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

Comment thread e2e/pnp/__tests__/undeclared-dependency.test.js

Comment thread CHANGELOG.md Outdated

SimenB reviewed May 19, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

Apply suggestion from @SimenB

3f8f664

SimenB approved these changes May 19, 2026

View reviewed changes

SimenB merged commit 5e56105 into jestjs:main May 19, 2026
88 of 89 checks passed

JounQin deleted the chore/bump_unrs-resolver branch May 19, 2026 07:35

Uh oh!

Conversation

JounQin commented Jul 6, 2025

Summary

Test plan

Uh oh!

netlify Bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

pkg-pr-new Bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JounQin Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

JounQin commented Jul 6, 2025

Uh oh!

cpojer commented Jul 9, 2025

Uh oh!

JounQin commented Jul 10, 2025

Uh oh!

SimenB Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

JounQin Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

cpojer commented Jul 27, 2025

Uh oh!

JounQin commented Jul 27, 2025

Uh oh!

tyadeola commented Sep 5, 2025

Summary

Test plan

Uh oh!

SimenB commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimenB left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify Bot commented Jul 6, 2025 •

edited

Loading

pkg-pr-new Bot commented Jul 6, 2025 •

edited

Loading

SimenB commented May 4, 2026 •

edited

Loading

netlify Bot commented May 19, 2026 •

edited

Loading