Per-file @jest/globals#15773
Merged
Merged
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This fixes jestjs#15772 by giving each import of @jest/globals its own synthetic module. My assumption is that making extra @jest/globals objects won't be a problem because @jest/globals will not have many imports from a single test suite and that Jest objects are relatively cheap to construct. If either of these assumptions is wrong, let me know. If this approach seems reasonable, I can see about adding test coverage. Fixes jestjs#15772
3a1f400 to
a46b5c0
Compare
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
cpojer
approved these changes
Aug 27, 2025
Member
cpojer
left a comment
There was a problem hiding this comment.
Yup, this makes sense.
Could you send a separate PR with a test?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #15772 by giving each import of @jest/globals its own synthetic module.
My assumption is that making extra @jest/globals objects won't be a problem because @jest/globals will not have many imports from a single test suite and that Jest objects are relatively cheap to construct. If either of these assumptions is wrong, let me know.
If this approach seems reasonable, I can see about adding test coverage.
Test plan
I tested against https://github.com/joshkel/jest-globals-bug and confirmed that the bug went away.
Fixes #15772