Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make @types/jsdom a peer dependency of jest-environment-jsdom-abstract#16166

Merged
SimenB merged 4 commits into
jestjs:mainfrom
jdufresne:peer-types-jsdom
May 12, 2026
Merged

Make @types/jsdom a peer dependency of jest-environment-jsdom-abstract#16166
SimenB merged 4 commits into
jestjs:mainfrom
jdufresne:peer-types-jsdom

Conversation

@jdufresne
Copy link
Copy Markdown
Contributor

@jdufresne jdufresne commented May 12, 2026 •
edited
Loading

Summary

Consumers of jest-environment-jsdom-abstract can now provide the type package version that matches their installed jsdom version. Just like the jsdom peer dependency, this uses a star to allow consumers to pick their precise version.

As a use case, @types/jsdom recently released a new version and even though I updated this package within my project,
jest-environment-jsdom-abstract continues to reference the older version.

Test plan

CI test suite. Run the code in my local projects.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 1c96551
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/6a030bfce956d6000759ccaa
😎 Deploy Preview https://deploy-preview-16166--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 12, 2026 •
edited
Loading

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16166

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16166

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16166

create-jest

npm i https://pkg.pr.new/create-jest@16166

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16166

expect

npm i https://pkg.pr.new/expect@16166

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16166

jest

npm i https://pkg.pr.new/jest@16166

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16166

jest-circus

npm i https://pkg.pr.new/jest-circus@16166

jest-cli

npm i https://pkg.pr.new/jest-cli@16166

jest-config

npm i https://pkg.pr.new/jest-config@16166

@jest/console

npm i https://pkg.pr.new/@jest/console@16166

@jest/core

npm i https://pkg.pr.new/@jest/core@16166

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16166

jest-diff

npm i https://pkg.pr.new/jest-diff@16166

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16166

jest-each

npm i https://pkg.pr.new/jest-each@16166

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16166

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16166

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16166

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16166

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16166

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16166

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16166

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16166

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16166

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16166

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16166

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16166

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16166

jest-mock

npm i https://pkg.pr.new/jest-mock@16166

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16166

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16166

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16166

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16166

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16166

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16166

jest-runner

npm i https://pkg.pr.new/jest-runner@16166

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16166

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16166

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16166

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16166

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16166

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16166

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16166

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16166

@jest/types

npm i https://pkg.pr.new/@jest/types@16166

jest-util

npm i https://pkg.pr.new/jest-util@16166

jest-validate

npm i https://pkg.pr.new/jest-validate@16166

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16166

jest-worker

npm i https://pkg.pr.new/jest-worker@16166

pretty-format

npm i https://pkg.pr.new/pretty-format@16166

commit: c74cad8

SimenB
SimenB requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Can you add it as a dependency in jest-environment-jsdom?

@jdufresne
Make @types/jsdom a peer dependency of jest-environment-jsdom-abstract
c74cad8 
Consumers of jest-environment-jsdom-abstract can now provide the type
package version that matches their installed jsdom version. Just like
the jsdom peer dependency, this uses a star to allow consumers to pick
their precise version.

As a use case, @types/jsdom recently released a new version and even
though I updated this package within my project,
jest-environment-jsdom-abstract continues to reference an older version.
@jdufresne
Copy link
Copy Markdown
Contributor Author

jdufresne commented May 12, 2026

Makes sense!

Can you add it as a dependency in jest-environment-jsdom?

Good call. I've done this in the latest push. Thanks.

SimenB
SimenB approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 3955d24 into jestjs:main May 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jdufresne @SimenB