Codestin Search App

jmuransky · 2026-05-12T10:11:11Z

Summary

Provides more descriptive error message so, that people trying to use new Jest will not spend too much time trying to figure out what went wrong.

Covers issue #16168

Test plan

I added tests covering the functionality.

…rent version of jest

netlify · 2026-05-12T10:11:17Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`204f8ff`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/6a0310cdf96279000800a945
😎 Deploy Preview	https://deploy-preview-16169--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2026-05-12T10:16:44Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16169

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16169

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16169

create-jest

npm i https://pkg.pr.new/create-jest@16169

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16169

expect

npm i https://pkg.pr.new/expect@16169

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16169

jest

npm i https://pkg.pr.new/jest@16169

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16169

jest-circus

npm i https://pkg.pr.new/jest-circus@16169

jest-cli

npm i https://pkg.pr.new/jest-cli@16169

jest-config

npm i https://pkg.pr.new/jest-config@16169

@jest/console

npm i https://pkg.pr.new/@jest/console@16169

@jest/core

npm i https://pkg.pr.new/@jest/core@16169

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16169

jest-diff

npm i https://pkg.pr.new/jest-diff@16169

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16169

jest-each

npm i https://pkg.pr.new/jest-each@16169

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16169

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16169

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16169

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16169

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16169

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16169

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16169

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16169

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16169

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16169

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16169

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16169

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16169

jest-mock

npm i https://pkg.pr.new/jest-mock@16169

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16169

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16169

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16169

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16169

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16169

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16169

jest-runner

npm i https://pkg.pr.new/jest-runner@16169

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16169

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16169

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16169

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16169

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16169

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16169

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16169

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16169

@jest/types

npm i https://pkg.pr.new/@jest/types@16169

jest-util

npm i https://pkg.pr.new/jest-util@16169

jest-validate

npm i https://pkg.pr.new/jest-validate@16169

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16169

jest-worker

npm i https://pkg.pr.new/jest-worker@16169

pretty-format

npm i https://pkg.pr.new/pretty-format@16169

commit: ecbae8c

SimenB · 2026-05-12T10:20:11Z

      '`moduleMocker` must be set on an environment when created',
    );
    this._moduleMocker = this._environment.moduleMocker;
+    if (typeof this._moduleMocker.clearMocksOnScope !== 'function') {


I don't think we should explode here. We should just skip the clearMocksOnScope call

diff --git i/packages/jest-runtime/src/index.ts w/packages/jest-runtime/src/index.ts index e85d58ed01..a67a073966 100644 --- i/packages/jest-runtime/src/index.ts +++ w/packages/jest-runtime/src/index.ts @@ -555,7 +555,7 @@ export default class Runtime { if (this._environment) { if (this._environment.global) { - this._moduleMocker.clearMocksOnScope(this._environment.global); + this._moduleMocker.clearMocksOnScope?.(this._environment.global); } if (this._environment.fakeTimers) {

it's a nice extra feature, but not require at all for the runtime to function

Ah right. I didn't have enough context knowledge to know that this thing is not actually required. I think there are other cases that basically die on the same thing (not sure though) - so I'll make sure to make this optional in every case and revert the error message.

In the end your change request was enough and there was no other case :)

…nts instead of throwing

SimenB

thanks!

dananaprey · 2026-05-15T08:59:11Z

Hi! When version with this fix will be published?

Faced same issue

jest 30.4.0 introduced clearMocksOnScope(), but did not deal properly with environments missing that method. The react-native jest environment seems to be missing it, causing the unit tests to fail. This is fixed by [jest#16169](jestjs/jest#16169) but has not been released yet. Once merged, the range can be `^30.4.0`.

Can be restored once jestjs/jest#16169 is released

jmuransky added 4 commits May 12, 2026 11:57

add check for supported jest environment, that is required to run cur…

b11ea59

…rent version of jest

fix type errors

748b565

Merge branch 'jestjs:main' into jest-environemnt-jsdom-version-warning

e3facbc

add preliminary version of CHANGELOG.md

e1bca63

update changelog to opened pull request

ded2d8b

SimenB requested changes May 12, 2026

View reviewed changes

jmuransky and others added 3 commits May 12, 2026 12:39

adjust jest to not actually throw on older versions of jest environme…

96daef1

…nts instead of throwing

typo fix

ecbae8c

Merge branch 'main' into jest-environemnt-jsdom-version-warning

204f8ff

SimenB approved these changes May 12, 2026

View reviewed changes

SimenB changed the title ~~Jest environemnt jsdom version warning~~ fix: Support older test environments whose moduleMocker does not implement clearMocksOnScope May 12, 2026

SimenB merged commit 28246a4 into jestjs:main May 12, 2026
8 of 9 checks passed

DK013 mentioned this pull request May 24, 2026

chore(deps-dev): bump jest and @types/jest dvai-global/dvai-bridge#11

Closed

colinrotherham mentioned this pull request May 28, 2026

Bump the test group across 1 directory with 7 updates nhsuk/nhsuk-frontend#1930

Merged

colinrotherham added a commit to nhsuk/nhsuk-frontend that referenced this pull request May 28, 2026

Roll back Jest updates due to mandatory module mocker issue

92209db

Can be restored once jestjs/jest#16169 is released

colinrotherham added a commit to nhsuk/nhsuk-frontend that referenced this pull request May 28, 2026

Roll back Jest updates due to mandatory module mocker issue

d96e8e8

Can be restored once jestjs/jest#16169 is released

colinrotherham added a commit to nhsuk/nhsuk-frontend that referenced this pull request May 28, 2026

Roll back Jest updates due to mandatory module mocker issue

7a62f56

Can be restored once jestjs/jest#16169 is released

colinrotherham added a commit to nhsuk/nhsuk-frontend that referenced this pull request May 28, 2026

Roll back Jest updates due to mandatory module mocker issue

088f99f

Can be restored once jestjs/jest#16169 is released

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Support older test environments whose `moduleMocker` does not implement `clearMocksOnScope`#16169

fix: Support older test environments whose `moduleMocker` does not implement `clearMocksOnScope`#16169
SimenB merged 8 commits into
jestjs:mainfrom
jmuransky:jest-environemnt-jsdom-version-warning

jmuransky commented May 12, 2026

Uh oh!

netlify Bot commented May 12, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 12, 2026 •

edited

Loading

Uh oh!

SimenB May 12, 2026

Uh oh!

jmuransky May 12, 2026

Uh oh!

jmuransky May 12, 2026

Uh oh!

SimenB left a comment

Uh oh!

Uh oh!

dananaprey commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jmuransky commented May 12, 2026

Summary

Test plan

Uh oh!

netlify Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

pkg-pr-new Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB May 12, 2026

Choose a reason for hiding this comment

Uh oh!

jmuransky May 12, 2026

Choose a reason for hiding this comment

Uh oh!

jmuransky May 12, 2026

Choose a reason for hiding this comment

Uh oh!

SimenB left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dananaprey commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented May 12, 2026 •

edited

Loading

pkg-pr-new Bot commented May 12, 2026 •

edited

Loading