MySQL Plugin: create and link my.cnf to allow configuring MySQL #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is an awesome addition! I added a similar feature for MariaDB, and also tweaked the detection logic for MySQL vs. MariaDB |
|
Hey John, thank you, looks perfect to me! |
Lagoja
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
$MYSQL_CONFenv var to the MySQL Plugin to allow a custommy.cnf(MySQL config file). MySQL does not provide an environment variable, command line flag, or anything else to change the location (it's always computed as$MYSQL_HOME/my.cnf), so we simply create a symlink there pointing to the user's config.How was it tested?