-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Documented the new web application deployer. #13084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jetty-12.1.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Simone Bordet <[email protected]>
documentation/jetty/modules/operations-guide/pages/modules/standard.adoc
Outdated
Show resolved
Hide resolved
jetty-core/jetty-deploy/src/main/config/modules/deployer-standard.mod
Outdated
Show resolved
Hide resolved
jetty-core/jetty-deploy/src/main/config/modules/deployment-scanner.mod
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/operations-guide/pages/modules/standard.adoc
Outdated
Show resolved
Hide resolved
@@ -1,5 +1,6 @@ | |||
[description] | |||
This module enables the direct Deployer, which simply adds and starts a context. | |||
This module enables the standard Deployer, which adds and starts ContextHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh? What is the deployer-standard
module? How is this different to the deployment-scanner
module? Shouldn't we have just one deployer
module, and if users want something different they come up with their own module that configures their own Scanner etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janbartel deployer-scanner
scans and creates the ContextHandler
(subclass); deployer-standard
links that ContextHandler
to the server.
Before linking it to the server, another module may decorate it or reconfigure it.
@@ -13,108 +13,258 @@ | |||
|
|||
= Web Application Deployment | |||
|
|||
The Jetty Web Application Deployment mechanism provides for: | |||
The Jetty server deploys each web application to a specific _environment_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Jetty server deploys each web application to a specific _environment_. | |
Jetty deploys each web application to a specific _environment_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no. "Jetty" is not defined (typically refers to the project), we have client and server, so it's really "The Jetty server".
documentation/jetty/modules/operations-guide/pages/deploy/index.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/operations-guide/pages/deploy/index.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/operations-guide/pages/deploy/index.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/operations-guide/pages/deploy/index.adoc
Outdated
Show resolved
Hide resolved
---- | ||
|
||
The contents of the `$JETTY_BASE/etc/{ee-current}-context.xml` then `$JETTY_BASE/etc/{ee-current}-feature.xml` files will be applied to the `wiki` webapp instance _before_ `wiki.xml`, allowing the contents of the latter to override the contents of the former. | ||
[[jetty-web-xml]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't document the jetty-web.xml
files in the section on deployment. It has nothing to do with deployment, it concerns only webapp startup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to know the existence of this feature if you want to properly prepare your application for deployment.
Is there a "webapp startup" documentation? If not, here would be the best place for now.
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
No description provided.