Replace RuntimeIOException with UncheckedIOException #13090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ore/jetty-fcgi/jetty-fcgi-client/src/main/java/org/eclipse/jetty/fcgi/generator/Flusher.java
Outdated
Show resolved
Hide resolved
lachlan-roberts
approved these changes
May 5, 2025
joakime
requested changes
May 5, 2025
...ore/jetty-fcgi/jetty-fcgi-client/src/main/java/org/eclipse/jetty/fcgi/generator/Flusher.java
Outdated
Show resolved
Hide resolved
sbordet
reviewed
May 5, 2025
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
May 5, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/NegotiatingClientConnection.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/RuntimeIOException.java
Outdated
Show resolved
Hide resolved
...-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletApiRequest.java
Show resolved
Hide resolved
...1/jetty-ee11-proxy/src/test/java/org/eclipse/jetty/ee11/proxy/AsyncMiddleManServletTest.java
Show resolved
Hide resolved
...-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiRequest.java
Show resolved
Hide resolved
...ee9/jetty-ee9-proxy/src/test/java/org/eclipse/jetty/ee9/proxy/AsyncMiddleManServletTest.java
Outdated
Show resolved
Hide resolved
joakime
requested changes
May 5, 2025
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
May 6, 2025
| @@ -127,7 +126,7 @@ public Callback join() | |||
| { | |||
| Throwable cause = getCause(); | |||
| ExceptionUtil.addSuppressedIfNotAssociated(cause, x); | |||
| throw new RuntimeIOException(cause); | |||
| throw ExceptionUtil.asRuntime(cause == null ? x : cause); | |||
There was a problem hiding this comment.
Here, throw new RuntimeException(cause) is clearer and shorter.
There was a problem hiding this comment.
@sbordet But cause might be null, in which case a NPE will be thrown and x will be lost. I'll handle the null case separately above.
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
sbordet
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the standard UncheckedIoException rather than our own