Issue #13050 - fix flaky websocket OnMessageStream tests #13093
+32
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
requested changes
May 5, 2025
...rg/eclipse/jetty/ee10/websocket/jakarta/common/AbstractJakartaWebSocketFrameHandlerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
requested changes
May 5, 2025
| @AfterAll | ||
| public static void stopContainer() throws Exception | ||
| @AfterEach | ||
| public void stopContainer() throws Exception | ||
| { | ||
| components.stop(); |
There was a problem hiding this comment.
You should really use LifeCycle.stop(components) and LifeCycle.stop(container).
If, for some reason, in startContainer() an exception is thrown, the field will be null, and calling stop() will cause an NPE.
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
approved these changes
May 5, 2025
olamy
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13050