tools/mpremote: Add readline support to mount. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards making the transport expose a Python API rather than functions that mostly print to stdout. Most use cases of `transport.eval()` are to get some state back from the device, so have it return as a value directly by default. Updates uses of `transport.eval()` to remove the parse argument where it now isn't needed, make the `rtc` command use eval/exec, and update the `mip` command to use eval's parsing. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <[email protected]>
This introduces a Python filesystem API on `Transport` that is implemented entirely with eval/exec provided by the underlying transport subclass. Updates existing mpremote filesystem commands (and `edit) to use this API. Also re-implements recursive `cp` to allow arbitrary source / destination. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <[email protected]>
- Adds transport API `fs_hashfile` to compute the hash of a file with given algorithm. - Adds command `mpremote hash file` to compute and print sha256 hash. - Uses the hash computation to improve speed of recursive file copy to avoid copying a file where the target is identical. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <[email protected]>
These tests are specifically for the command-line interface and cover: - resume/soft-reset/connect/disconnect - mount - fs cp,touch,mkdir,cat,hash,rm,rmdir - eval/exec/run This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <[email protected]>
If possible it will use the board's support (e.g. built-in hashlib or hashlib from micropython-lib), but will fall back to downloading the file and using the local implementation. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <[email protected]>
Makes the filesystem command give standard error messages rather than just printing the exception from the device. Makes the distinction between CommandError and TransportError clearer. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <[email protected]>
This significantly speeds up readline on files opened directly from a mpremote mount. Signed-off-by: Andrew Leech <[email protected]>
|
You probably want to open this on the upstream repo. |
|
I made the change on top of tools/mpremote: Recursive directory sync, regression tests, transport filesystem API, hash command. #11777 so pushed it here for first pass / guage interest. |
|
Ah, I see! If your code is doing a lot of readline's then this is definitely an improvement. But if you don't use readline you are unnecessarily paying for the size of the VFS hook code. Although the change in size of that VFS hook code is pretty small. And the existing loop that did So, I'd say this is a good improvement, worth doing. |
6f55e00 to
42c1997
Compare
8623a51 to
e5eeaa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly speeds up readline on files opened directly from a mpremote mount.
With a local file
hello.pythat's 5741 bytes, usingmpremote mount .with a pyboard-d:Without this MR, this reports
16650(ms)With this MR, it drops to
1415