[Repo Assist] Fix needsRebase=true incorrectly set for queued branches in JSON output - #10

🤖 This is an automated pull request from Repo Assist, an AI assistant.

Problem

gh stack view --json sets needsRebase: true for branches whose PR is currently in the merge queue. This is incorrect: a branch in the merge queue cannot be rebased — doing so would invalidate the queue entry. Any automation script that checks needsRebase and acts on it (e.g. by running gh stack rebase) would fail or silently corrupt the queued PR.

Root cause

In viewJSON (cmd/view.go), NeedsRebase was skipped for merged branches but not for queued ones:

// Before
if !jb.IsMerged {
    baseBranch := s.ActiveBaseBranch(b.Branch)
    if isAnc, err := git.IsAncestor(baseBranch, b.Branch); err == nil && !isAnc {
        jb.NeedsRebase = true
    }
}

Fix

Mirror the existing merged-branch skip for queued branches:

// After
if !jb.IsMerged && !jb.IsQueued {
    baseBranch := s.ActiveBaseBranch(b.Branch)
    if isAnc, err := git.IsAncestor(baseBranch, b.Branch); err == nil && !isAnc {
        jb.NeedsRebase = true
    }
}

Test

Added TestViewJSON_QueuedBranchNeedsRebaseFalse in cmd/view_test.go:

• Configures IsAncestor to return false for all branches (worst case)
• Verifies queued branch has needsRebase: false
• Verifies non-queued open branch still has needsRebase: true

Test Status

Tests could not be run in this environment (Go 1.25.7 toolchain download requires sum.golang.org, which is blocked by the firewall). CI will run the full test suite. The change is a single-line predicate addition in a well-understood path with a new test covering the invariant directly.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

network:
  allowed:
    - defaults
    - "sum.golang.org"

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@11c9a2c442e519ff2b427bf58679f5a525353f76