[Repo Assist] Fix gh stack up/down navigation when on a queued branch - #17

🤖 This is an automated pull request from Repo Assist, an AI assistant.

Summary

gh stack up / gh stack down behaved incorrectly when the current branch was queued (in a merge queue).

Root cause

// Before (cmd/navigate.go ~L100)
onMerged := s.Branches[idx].IsMerged()  // false for queued branches!

IsQueued() and IsMerged() are both "inactive" states, but the navigation code only recognised IsMerged(). When you were on a queued branch:

• onMerged = false → fell into the "active branch" navigation path
• activeIndices = s.ActiveBranchIndices() → queued branch not included
• activePos = -1 (branch not found)
• newActivePos = -1 + delta → for up (+1): index 0 (first active); for down (-1): clamped to 0

Both directions ended up at activeIndices[0] — the first active branch — regardless of where in the stack the queued branch sat. For example, with stack [b1, b2(queued), b3] on b2:

With a deeper stack like [b1, b2, b3(queued), b4, b5] on b3:

Fix

• Renamed onMerged → onSkipped, using IsSkipped() (= IsMerged() || IsQueued())
• Both merged and queued branches now navigate by raw index (±1 step), consistent with existing merged-branch behaviour
• Added a separate warning message for queued branches: "Warning: you are on queued branch %q"
• Updated the skip counter (in the active-branch path) from IsMerged() → IsSkipped() and the message from "Skipped N merged branches" → "Skipped N inactive branches"

Relationship to other PRs

• PR [Repo Assist] Fix navigate skip counter to include queued branches #14 fixed the skip counter message only — it did not fix the on-queued-branch navigation. This PR is complementary and does not conflict with [Repo Assist] Fix navigate skip counter to include queued branches #14.
• PR [Repo Assist] Fix gh stack top to skip merged/queued branches #16 fixes gh stack top to use LastActiveBranchIndex() — unrelated to this change.

Test Status

⚠️ Tests could not be run in this environment due to network restrictions preventing Go toolchain download (sum.golang.org is blocked). The CI workflow (test.yml) will run tests on GitHub.

Two new tests cover the fixed behaviour:

• TestNavigate_UpFromQueuedBranch — verifies up-navigation steps to the adjacent branch above
• TestNavigate_DownFromQueuedBranch — verifies down-navigation steps to the adjacent branch below

Existing tests are unaffected: TestNavigate_SkipsMergedBranches asserts Contains(output, "Skipped") which matches the updated "Skipped N inactive branches" message; TestNavigate_AllMerged_Up checks "you are on merged branch" which is still emitted in the IsMerged() case.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

network:
  allowed:
    - defaults
    - "sum.golang.org"

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@11c9a2c442e519ff2b427bf58679f5a525353f76