[Repo Assist] Fix viewFullStatic: add queued separator and correct branch coloring - #19
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
viewFullStatic (non-interactive / static full view) was missing the
'queued' section separator that viewShort already shows. Additionally,
queued branches were rendered in magenta (same as merged branches)
instead of in warning color (yellow), and active branches had magenta
applied unnecessarily.
Changes:
- Add a 'queued' separator (βββ queued βββ) when transitioning from
active to queued section, consistent with viewShort behaviour.
- Update the merged separator comment to reflect that queued branches
also appear above it.
- Switch branch name coloring to a switch statement:
merged β magenta (unchanged)
queued β warning/yellow (was magenta)
current β cyan (unchanged)
active β uncolored default (was magenta)
- Add TestViewFullStatic_QueuedStack and
TestViewFullStatic_MixedQueuedAndMerged to cover the new behaviour.
Co-authored-by: Copilot <[email protected]>
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π€ This is an automated pull request from Repo Assist, an AI assistant.
Summary
gh stack view(full view, non-interactive/static mode) was missing the queued section separator thatgh stack view --shortalready shows. Additionally, queued branches were rendered in magenta (the merged-branch color) instead of warning/yellow, and active (non-merged, non-queued) branches were unnecessarily colored magenta.Root cause
viewFullStaticwas written before queued-branch support was added. The separator and coloring logic were never updated to handle the queued state, resulting in inconsistent behavior between--shortand the default full view.Changes
cmd/view.goβviewFullStaticβββ merged βββseparatorβββ queued βββseparator when transitioning from active β queued sectioncmd/view_test.goTestViewFullStatic_QueuedStack: verifies queued separator andβicon appear in static full-view outputTestViewFullStatic_MixedQueuedAndMerged: verifies both separators appear in the correct order (queued before merged)Consistency
After this fix,
viewFullStaticmatchesviewShortsemantics:Test Status
Tests could not be executed locally due to Go toolchain version mismatch in the CI agent environment (
go 1.25.7required;go 1.24.13available) and network restrictions onsum.golang.org. The CI workflow (test.yml) will run tests on GitHub. The changes are straightforward display-logic adjustments with no algorithmic risk.Warning
The following domain was blocked by the firewall during workflow execution:
sum.golang.orgTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.