DIFF Create private _pairwise_distances_reductions submodule #14

jjerphan · 2022-06-10T09:02:14Z

Reference Issues/PRs

What does this implement/fix? Explain your changes.

The single source file is split in several files to create a private submodule:

an extension per file (similarly to the tree submodule)
dispatchers are currently present with their associated implementation so as to be able to template implementation using Tempita
import paths have not changed for Python callers
a testing utils which was used in neighbors' tests as been moved to utils._testing

Any other comments?

@jeremiedbb in scikit-learn#23515 (review) proposed to group dispatchers together. A proposition is made in this regard in the last commit, 83a950f.

This is used as a diff for now but this branch might be used to open another PR.

…-learn#23497) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Loïc Estève <[email protected]>

ogrisel

The new code organization looks good to me.

sklearn/metrics/_pairwise_distances_reduction/__init__.py

…scikit-learn#23558)

…rn#23587) Co-authored-by: Thomas J. Fan <[email protected]>

jeremiedbb

I like the new layout as well. The tests could stay in metrics/tests but no strong opinion.

sklearn/metrics/_pairwise_distances_reduction/_radius_neighborhood.pxd

sklearn/utils/_testing.py

Co-authored-by: Pierre Ablin <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>

…scikit-learn#22268) * memory improvements and fast execution with np.einsum than np.dot

…e main page (scikit-learn#23613) Co-authored-by: Thomas J. Fan <[email protected]>

…an intercept (scikit-learn#23608)

Co-authored-by: Jérémie du Boisberranger <[email protected]>

Co-authored-by: Olivier Grisel <[email protected]>

Co-authored-by: Loïc Estève <[email protected]>

…#23693)

Update reference link to "A survey of Partial Least Squares (PLS) methods, with emphasis on the two-block case" by JA Wegelin

…t-learn#23658) Co-authored-by: Loïc Estève <[email protected]>

Co-authored-by: Loïc Estève <[email protected]>

…c functions (scikit-learn#23514) Co-authored-by: Julien Jerphanion <[email protected]>

Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>

…D array (scikit-learn#23548) * Change input array to ensure_2d=True * Reshape input list to 2D if metric is coverage_error * Add test for error message with 1D array on coverage_error * Modify 1D error message test * Use parametrize to test different 1d arrays * Explain why reshape in test_regression_thresholded_inf_nan_input * Add changelog entry for this fix * Add test comments to sklearn/metrics/tests/test_ranking.py Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>

Updated link to book chapter in "Machine Learning: An Algorithmic Perspective" by S. Marsland.

Co-authored-by: Loïc Estève <[email protected]>

…#23706) Co-authored-by: Loïc Estève <[email protected]>

…23712)

Updated link to reference "Random Fourier approximations for skewed multiplicative histogram kernels"

…3659)

…-learn#23515) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>

…ipy/scipy#16432 (scikit-learn#23597) Co-authored-by: Thomas J. Fan <[email protected]>

jjerphan · 2022-06-22T10:10:48Z

Closed for scikit-learn#23724.

From: #14 (review) Co-authored-by: Jérémie du Boisberranger <[email protected]>

glemaitre and others added 2 commits June 9, 2022 16:32

FIX make pandas and liac arff parser quoting behaviour closer (scikit…

8515b48

…-learn#23497) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Loïc Estève <[email protected]>

MNT fix typo in test function name (scikit-learn#23573)

2f787f4

jjerphan mentioned this pull request Jun 10, 2022

MAINT Introduce dispatchers for PairwiseDistancesReductions scikit-learn/scikit-learn#23515

Merged

jjerphan added the No Changelog Needed label Jun 10, 2022

jjerphan force-pushed the maint/pdr-private-submodule branch 3 times, most recently from 83a950f to 5b250f1 Compare June 10, 2022 14:27

jjerphan changed the title ~~MAINT Create private _pairwise_distances_reductions submodule~~ DIFF Create private _pairwise_distances_reductions submodule Jun 10, 2022

jjerphan marked this pull request as draft June 10, 2022 16:36

ogrisel approved these changes Jun 10, 2022

View reviewed changes

sklearn/metrics/_pairwise_distances_reduction/__init__.py Outdated Show resolved Hide resolved

jeremiedbb and others added 3 commits June 13, 2022 11:17

MNT Param validation: Make it possible to mark a constraint as hidden (…

de659b9

…scikit-learn#23558)

DOC Fix typos in Feature Selection page (scikit-learn#23601)

d7315b6

DOC / MAINT Link to logos in Community section of website (scikit-lea…

fc9be34

…rn#23587) Co-authored-by: Thomas J. Fan <[email protected]>

jeremiedbb reviewed Jun 13, 2022

View reviewed changes

sklearn/metrics/_pairwise_distances_reduction/_radius_neighborhood.pxd Outdated Show resolved Hide resolved

sklearn/utils/_testing.py Show resolved Hide resolved

thomasjpfan and others added 16 commits June 14, 2022 11:13

MNT Removes parallel sphinx build by default on OSX (scikit-learn#23492)

bb0ea58

ENH Add eigh solver to FastICA (scikit-learn#22527)

54c1503

Co-authored-by: Pierre Ablin <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>

ENH Optimise decomposition.FastICA.fit memory footprint and runtime (…

8308646

…scikit-learn#22268) * memory improvements and fast execution with np.einsum than np.dot

DOC fix links with broken anchor (scikit-learn#23611)

1650347

DOC / MAINT Add "Logos & Branding" section to Community section of th…

d37ae33

…e main page (scikit-learn#23613) Co-authored-by: Thomas J. Fan <[email protected]>

MNT fix body too long in update_tracking_issue.py (scikit-learn#23615)

dbe3945

Configure sphinx linkcheck to be more usable (scikit-learn#23577)

a5828d6

DOC Fix typo in Clustering page (scikit-learn#23625)

2cfe261

DOC Fix typo in manifold page (scikit-learn#23623)

cabcd28

DOC Fix typos in Gaussian mixture page (scikit-learn#23622)

56c1f68

FIX logistic regression with newton_cg solver, a single feature, and …

59473a9

…an intercept (scikit-learn#23608)

MAINT Create private _pairwise_distances_reductions submodule

3a8eb53

MAINT Group dispatchers in a single file

5c855fe

DOC Fix typo

a8c7dfa

Co-authored-by: Jérémie du Boisberranger <[email protected]>

DOC Move comment where appropriate

fd754d5

MAINT Dispatch _sqeuclidean_row_norms

79c8188

Co-authored-by: Olivier Grisel <[email protected]>

kanissh and others added 27 commits June 20, 2022 10:47

DOC fix link to Fonds de la Recherche Scientifique (scikit-learn#23678)

b461bea

DOC fix link to SVD based initialisation article (scikit-learn#23687)

54af694

DOC fix link to Imageio documentation (scikit-learn#23689)

fdfa0f8

Co-authored-by: Loïc Estève <[email protected]>

DOC fix link to Statistical Learning with Sparsity book (scikit-learn…

150d1db

…#23693)

DOC update link to reference article (scikit-learn#23680)

e4d0c6d

Update reference link to "A survey of Partial Least Squares (PLS) methods, with emphasis on the two-block case" by JA Wegelin

MAINT update test since SettingWithCopyWarning location change (sciki…

8a07dc2

…t-learn#23658) Co-authored-by: Loïc Estève <[email protected]>

DOC fix wording in Outlier Detection docs (scikit-learn#23690)

11f90a1

DOC fix typos an -> a (scikit-learn#23684)

f1c5a39

DOC fix link to NumFOCUS donation page (scikit-learn#23695)

968544b

Co-authored-by: Loïc Estève <[email protected]>

DOC Fix broken link to pandas doc (scikit-learn#23696)

0977148

MNT Param validation: Add a common test for param validation of publi…

cc6806b

…c functions (scikit-learn#23514) Co-authored-by: Julien Jerphanion <[email protected]>

DOC fix high-dimension distribution link (scikit-learn#23698)

d5ec5ab

DOC FIX Logo 3 image link to display correct image (scikit-learn#23634)

def466a

DOC Rework plot_document_clustering.py example (scikit-learn#23528)

0943f52

Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>

DOF fix robust regression example link (scikit-learn#23660)

30d8700

DOC fix Jake's tutorial link (scikit-learn#23703)

b88f0bb

DOC fix link to reference book (scikit-learn#23705)

638d516

Updated link to book chapter in "Machine Learning: An Algorithmic Perspective" by S. Marsland.

DOC fix scipy broken link (scikit-learn#23697)

6db963c

Co-authored-by: Loïc Estève <[email protected]>

DOC fix broken link Sequential Karhunen-Loeve Transform (scikit-learn…

25b5363

…#23706) Co-authored-by: Loïc Estève <[email protected]>

DOC Fix random_state parameter definition in docstring (scikit-learn#…

fb565d6

…23712)

DOC fix link to reference (scikit-learn#23713)

55dfde5

Updated link to reference "Random Fourier approximations for skewed multiplicative histogram kernels"

MAINT make sure that x0 is 1D when passed to minimize (scikit-learn#2…

67c7984

…3659)

MAINT Introduce dispatchers for PairwiseDistancesReductions (scikit…

74cda4b

…-learn#23515) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>

MAINT make explicit casting when using iloc (scikit-learn#23649)

ac8dd1d

MNT Update sklearn.externals._lobpcg.lobpcg docstring according to sc…

f78f6b2

…ipy/scipy#16432 (scikit-learn#23597) Co-authored-by: Thomas J. Fan <[email protected]>

Merge branch 'main' into maint/pdr-private-submodule

8f2c106

jjerphan closed this Jun 22, 2022

jjerphan added a commit that referenced this pull request Jun 22, 2022

Apply review comment

8f791b6

From: #14 (review) Co-authored-by: Jérémie du Boisberranger <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DIFF Create private _pairwise_distances_reductions submodule #14

DIFF Create private _pairwise_distances_reductions submodule #14

Uh oh!

jjerphan commented Jun 10, 2022 •

edited

Loading

Uh oh!

ogrisel left a comment

Uh oh!

Uh oh!

jeremiedbb left a comment

Uh oh!

Uh oh!

Uh oh!

jjerphan commented Jun 22, 2022

Uh oh!

Uh oh!

DIFF Create private _pairwise_distances_reductions submodule #14

DIFF Create private _pairwise_distances_reductions submodule #14

Uh oh!

Conversation

jjerphan commented Jun 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeremiedbb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jjerphan commented Jun 22, 2022

Uh oh!

Uh oh!

jjerphan commented Jun 10, 2022 •

edited

Loading